All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Tom Scogland <scogland1@llnl.gov>,
	 Tom Scogland via GitGitGadget <gitgitgadget@gmail.com>,
	 git@vger.kernel.org
Subject: Re: [PATCH v2] archive: make --add-virtual-file honor --prefix
Date: Fri, 14 Jun 2024 11:07:41 -0700	[thread overview]
Message-ID: <xmqqh6dvflea.fsf@gitster.g> (raw)
In-Reply-To: <01b21870-b37e-47fe-9bd7-225499ae5eaf@web.de> ("René Scharfe"'s message of "Mon, 20 May 2024 19:07:22 +0200")

René Scharfe <l.s.r@web.de> writes:

> I'm not sure I have an opinion on that topic, yet.  Fixing the
> documentation is certainly easier.  Adding the prefix to the path of
> virtual files as well is a breaking change.  I feel that the easier
> route should at least be mentioned in the commit message and why it
> was not taken.

It has been a few weeks since this discussion stalled.  Let me make
an executive decision on the direction here---let's keep the behaviour
and align the documentation so that we won't break existing users.

Thanks.

  reply	other threads:[~2024-06-14 18:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 21:15 [PATCH] archive: make --add-virtual-file honor --prefix Tom Scogland via GitGitGadget
2024-05-15 15:23 ` Junio C Hamano
2024-05-15 16:27   ` Tom Scogland
2024-05-17 17:34 ` [PATCH v2] " Tom Scogland via GitGitGadget
2024-05-17 23:33   ` Junio C Hamano
2024-05-18  0:26     ` Tom Scogland
2024-05-19 13:25   ` René Scharfe
2024-05-20 16:10     ` Tom Scogland
2024-05-20 17:07       ` René Scharfe
2024-06-14 18:07         ` Junio C Hamano [this message]
2024-06-14 18:40           ` [PATCH] archive: document that --add-virtual-file takes full path Junio C Hamano
2024-06-25 22:43             ` Junio C Hamano
2024-06-26 19:05               ` René Scharfe
2024-05-20 17:55       ` [PATCH v2] archive: make --add-virtual-file honor --prefix Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh6dvflea.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=l.s.r@web.de \
    --cc=scogland1@llnl.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.