From: Junio C Hamano <gitster@pobox.com>
To: Josh Steadmon <steadmon@google.com>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: [PATCH] connect, protocol: log negotiated protocol version
Date: Wed, 04 Aug 2021 14:56:47 -0700 [thread overview]
Message-ID: <xmqqh7g4naao.fsf@gitster.g> (raw)
In-Reply-To: <YQsIscghtbpKI/OI@google.com> (Josh Steadmon's message of "Wed, 4 Aug 2021 14:37:53 -0700")
Josh Steadmon <steadmon@google.com> writes:
> On 2021.08.03 17:12, Taylor Blau wrote:
>> On Tue, Aug 03, 2021 at 01:13:02PM -0700, Josh Steadmon wrote:
> V2 will include a format_protocol_version().
> ...
> Thanks for catching this dumb mistake. Fixed in V2, and added tests to
> make sure the trace message shows up on both client- & server-side.
Thanks, both. I was about to merge the original one to 'next' as a
"good enough" version, but you caught me just in time ;-)
next prev parent reply other threads:[~2021-08-04 21:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 20:13 [PATCH] connect, protocol: log negotiated protocol version Josh Steadmon
2021-08-03 21:12 ` Taylor Blau
2021-08-04 21:37 ` Josh Steadmon
2021-08-04 21:56 ` Junio C Hamano [this message]
2021-08-04 22:17 ` [PATCH v2 0/2] " Josh Steadmon
2021-08-04 22:17 ` [PATCH v2 1/2] protocol: add protocol version formatting function Josh Steadmon
2021-08-04 23:32 ` Ævar Arnfjörð Bjarmason
2021-08-04 22:17 ` [PATCH v2 2/2] connect, protocol: log negotiated protocol version Josh Steadmon
2021-08-04 22:28 ` Eric Sunshine
2021-08-06 21:15 ` Josh Steadmon
2021-08-04 23:40 ` Ævar Arnfjörð Bjarmason
2021-08-05 1:26 ` Taylor Blau
2021-08-05 2:47 ` Ævar Arnfjörð Bjarmason
2021-08-06 21:22 ` Josh Steadmon
2021-08-10 17:20 ` [PATCH v3] " Josh Steadmon
2021-08-16 18:03 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7g4naao.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.