All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Peter Oliver via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Peter Oliver <git@mavit.org.uk>
Subject: Re: [PATCH] doc: point to diff attribute in patch format docs
Date: Tue, 27 Apr 2021 16:40:00 +0900	[thread overview]
Message-ID: <xmqqh7jsdvlb.fsf@gitster.g> (raw)
In-Reply-To: <pull.940.git.1619463549689.gitgitgadget@gmail.com> (Peter Oliver via GitGitGadget's message of "Mon, 26 Apr 2021 18:59:09 +0000")

"Peter Oliver via GitGitGadget" <gitgitgadget@gmail.com> writes:

> @@ -11,7 +11,7 @@ linkgit:git-diff-files[1]
>  with the `-p` option produces patch text.
>  You can customize the creation of patch text via the
>  `GIT_EXTERNAL_DIFF` and the `GIT_DIFF_OPTS` environment variables
> -(see linkgit:git[1]).
> +(see linkgit:git[1]), and the `diff` attribute (see linkgit:gitattributes[5]).
>  
>  What the -p option produces is slightly different from the traditional
>  diff format:
> @@ -74,6 +74,10 @@ separate lines indicate the old and the new mode.
>        rename from b
>        rename to a
>  
> +5.  Hunk headers mention the name of the function to which the hunk
> +    applies.  See linkgit:gitattributes[5] for details of how to tailor
> +    to this to specific languages.

Shouldn't this part be as helpful as the change you made to the
earlier part by mentioning that the user wants to look at a specific
part of the document, instead of reading the entire gitattributes(5)
manpage?  Perhaps "Defining a custom hunk header" section is what
they want to refer to.


>  Combined diff format
>  --------------------
>
> base-commit: 48bf2fa8bad054d66bd79c6ba903c89c704201f7

  reply	other threads:[~2021-04-27  7:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 18:59 [PATCH] doc: point to diff attribute in patch format docs Peter Oliver via GitGitGadget
2021-04-27  7:40 ` Junio C Hamano [this message]
2021-04-27 10:37   ` Peter Oliver
2021-04-27 11:02 ` [PATCH v2] " Peter Oliver via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh7jsdvlb.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@mavit.org.uk \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.