From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Lars Schneider <larsxschneider@gmail.com>,
Jeff King <peff@peff.net>, Git Mailing List <git@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: USE_SHA1DC is broken in pu
Date: Tue, 21 Mar 2017 13:16:29 -0700 [thread overview]
Message-ID: <xmqqh92mo06a.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1703212105030.3767@virtualbox> (Johannes Schindelin's message of "Tue, 21 Mar 2017 21:09:42 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Fri, 17 Mar 2017, Lars Schneider wrote:
>
>> > On 17 Mar 2017, at 11:18, Lars Schneider <larsxschneider@gmail.com>
>> > wrote:
>> >
>> > Would it make sense/have value to add a job to our TravisCI build [1]
>> > that compiles Git in a few variations with some high profile switches
>> > such as USE_SHA1DC? Running all the tests for these variations would
>> > probably take to long but just compiling would be less than 2min per
>> > variation.
>>
>> ... or just run individual tests instead of the entire test suite for
>> these variations (e.g. only t0013 for the USE_SHA1DC variation).
>
> The best solution may be to open a PR with .travis.yml patched to enable
> this flag. And then report back to he mailing list because the gentle
> people here are not that used to paying attention to Continuous Testing
> :-D
Actually, the best solution may be to do nothing ;-) With the
current incarnation parked in 'pu' (or I may have already merged it
to 'next'), without any explicit VARIANT_SHA1 request to $(MAKE), we
default to use the DC_SHA1 variant.
Those who are paying attention to Travis would have noticed this by
now, I thought ;-).
next prev parent reply other threads:[~2017-03-21 20:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 19:22 USE_SHA1DC is broken in pu Linus Torvalds
2017-03-16 19:41 ` Jeff King
2017-03-16 19:44 ` Linus Torvalds
2017-03-16 19:46 ` Junio C Hamano
2017-03-16 19:51 ` Linus Torvalds
2017-03-16 20:26 ` Linus Torvalds
2017-03-16 19:41 ` Junio C Hamano
2017-03-17 3:18 ` Lars Schneider
2017-03-17 3:32 ` Lars Schneider
2017-03-21 20:09 ` Johannes Schindelin
2017-03-21 20:16 ` Junio C Hamano [this message]
2017-03-22 14:32 ` Johannes Schindelin
2017-03-22 22:02 ` Jonathan Nieder
2017-03-23 16:43 ` Johannes Schindelin
2017-03-23 17:16 ` Linus Torvalds
2017-03-23 17:47 ` Jeff King
2017-03-23 19:02 ` Junio C Hamano
2017-03-23 22:22 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh92mo06a.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.