From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jeremy Huddleston Sequoia <jeremyhu@apple.com>,
git@vger.kernel.org, Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER
Date: Mon, 10 Oct 2016 09:46:39 -0700 [thread overview]
Message-ID: <xmqqh98kgnio.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161010131041.lpdh4a7nol24hsz2@sigill.intra.peff.net> (Jeff King's message of "Mon, 10 Oct 2016 09:10:41 -0400")
Jeff King <peff@peff.net> writes:
> On Sun, Oct 09, 2016 at 07:53:23PM -0700, Jeremy Huddleston Sequoia wrote:
>
>> Subject: Re: [PATCH] t4014-format-patch: Adjust git_version regex to better
>> handle distro changes to DEF_VER
>>
>> Regressed-in: 480871e09ed2e5275b4ba16b278681e5a8c122ae
>> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
>
> I see there was a discussion elsewhere on the list about exactly what
> you are putting into DEF_VAR that causes the problem. Perhaps the commit
> message here would be a good place to mention that, why the current
> regex breaks it, and why your new version fixes not only it, but other
> possible values of DEF_VAR.
Ah, should have known that you'd already be helping with this.
Thanks.
next prev parent reply other threads:[~2016-10-10 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 2:53 [PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER Jeremy Huddleston Sequoia
2016-10-10 3:04 ` Josh Triplett
2016-10-10 4:08 ` Jeremy Huddleston Sequoia
2016-10-10 13:10 ` Jeff King
2016-10-10 16:37 ` Jeremy Huddleston Sequoia
2016-10-10 16:46 ` Junio C Hamano [this message]
2016-10-10 16:42 ` Junio C Hamano
2016-10-10 17:01 ` Jeremy Huddleston Sequoia
2016-10-11 20:06 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh98kgnio.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jeremyhu@apple.com \
--cc=josh@joshtriplett.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.