From: Junio C Hamano <gitster@pobox.com>
To: David Turner <novalis@novalis.org>
Cc: git@vger.kernel.org, peff@peff.net, mhagger@alum.mit.edu,
David Turner <dturner@twosigma.com>
Subject: Re: [PATCH 2/2] fsck: handle bad trees like other errors
Date: Mon, 26 Sep 2016 13:08:33 -0700 [thread overview]
Message-ID: <xmqqh992qv9a.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1474918365-10937-3-git-send-email-novalis@novalis.org> (David Turner's message of "Mon, 26 Sep 2016 15:32:45 -0400")
David Turner <novalis@novalis.org> writes:
> From: David Turner <dturner@twosigma.com>
>
> Instead of dying when fsck hits a malformed tree object, log the error
> like any other and continue. Now fsck can tell the user which tree is
> bad, too.
>
> Signed-off-by: David Turner <dturner@twosigma.com>
> ---
> fsck.c | 18 +++--
> t/t1450-fsck.sh | 17 ++++-
> .../307e300745b82417cc1a903f875c7d22e45ef907 | 4 +
To prevent further headaches in this directory, can we have
.gitattributes that tells us that everything in there are binary
files? Something like the attached.
The other object was transferred as a binary patch, but I have no
faith in what I applied from your e-mail message for this file that
went though latin-1 to utf-8 conversion X-<.
t/t1450/bad-objects/.gitattributes | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/t1450/bad-objects/.gitattributes b/t/t1450/bad-objects/.gitattributes
new file mode 100644
index 0000000..a173f27
--- /dev/null
+++ b/t/t1450/bad-objects/.gitattributes
@@ -0,0 +1 @@
+[0-9a-f]*[0-9a-f] -diff
next prev parent reply other threads:[~2016-09-26 20:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 19:32 [PATCH 0/2] tree-walk improvements David Turner
2016-09-26 19:32 ` [PATCH 1/2] tree-walk: be more specific about corrupt tree errors David Turner
2016-09-27 5:14 ` Jeff King
2016-09-27 5:35 ` Junio C Hamano
2016-09-27 15:21 ` David Turner
2016-09-26 19:32 ` [PATCH 2/2] fsck: handle bad trees like other errors David Turner
2016-09-26 19:51 ` Junio C Hamano
2016-09-26 20:08 ` Junio C Hamano [this message]
2016-09-26 20:11 ` Junio C Hamano
2016-09-27 5:27 ` Jeff King
2016-09-27 15:19 ` David Turner
2016-09-27 19:19 ` thoughts on error passing, was " Jeff King
2016-09-27 22:57 ` David Turner
2016-09-28 6:54 ` Jeff King
2016-09-28 5:01 ` Michael Haggerty
2016-09-28 8:58 ` Jeff King
2016-09-28 18:02 ` Junio C Hamano
2016-09-26 19:39 ` [PATCH 0/2] tree-walk improvements Stefan Beller
2016-09-26 19:43 ` Junio C Hamano
2016-09-26 20:22 ` David Turner
2016-09-27 0:35 ` Junio C Hamano
2016-09-26 21:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh992qv9a.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dturner@twosigma.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=novalis@novalis.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.