All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, jugg@hotmail.com
Subject: Re: [PATCH/RFC 2/2] receive-pack: hint that the user can stop "git push" at auto gc time
Date: Tue, 04 Feb 2014 10:25:31 -0800	[thread overview]
Message-ID: <xmqqha8eag6c.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1391496765-29564-2-git-send-email-pclouds@gmail.com> ("Nguyễn	Thái Ngọc Duy"'s message of "Tue, 4 Feb 2014 13:52:45 +0700")

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> Housekeeping jobs like auto gc generally should not get in the way.
> Users who are pushing may not want to wait until auto gc is done on
> the server. Give a hint for those users that it's safe now to break
> "git push" and stop waiting.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  This bandage patch may be a good compromise between running auto gc
>  and not annoying users much.
>  
>  If I'm not mistaken, when ^C on "git push" this way, gc will still be
>  running until it needs to print something out (which it should not
>  normally because of --quiet). The user won't see gc errors, but the
>  user generally can't do much anyway.

If you are over local transport, I would think you would kill the
both ends.  Also, wouldn't killing "git push" before it is done
talking with the receive-pack stop it before it has a chance to
update the remote tracking refs to pretend as if it fetched from
there immediately after a push?

So, no. I do not think we should ever encourage "if this bothers
you, you can ^C it".  Making it not to bother is fine, though.

  reply	other threads:[~2014-02-04 18:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04  2:20 bug? git push triggers auto pack when gc.auto = 0 chris
2014-02-04  2:41 ` Duy Nguyen
2014-02-04  5:13   ` chris
2014-02-04  6:02     ` Duy Nguyen
2014-02-04  6:52       ` [PATCH 1/2] receive-pack: update $GIT_DIR/info before auto garbage collection Nguyễn Thái Ngọc Duy
2014-02-04  6:52         ` [PATCH/RFC 2/2] receive-pack: hint that the user can stop "git push" at auto gc time Nguyễn Thái Ngọc Duy
2014-02-04 18:25           ` Junio C Hamano [this message]
2014-02-04 18:32             ` Junio C Hamano
2014-02-07 12:36               ` [PATCH/RFC 2/2] receive-pack: hint that the user can stop chris
2014-02-07 13:05                 ` Duy Nguyen
2014-02-07 16:47                   ` chris
2014-02-08  7:08               ` [PATCH v2 1/2] daemon: move daemonize() to libgit.a Nguyễn Thái Ngọc Duy
2014-02-08  7:08                 ` [PATCH v2 2/2] gc: config option for running --auto in background Nguyễn Thái Ngọc Duy
2014-02-10 11:03                   ` Erik Faye-Lund
2014-02-10 13:17                     ` Duy Nguyen
2014-02-10 13:33                       ` Erik Faye-Lund
2014-02-10 18:43                       ` Junio C Hamano
2014-02-10 19:11                         ` Junio C Hamano
2014-02-12  1:53                           ` Duy Nguyen
2014-02-12 17:36                             ` Junio C Hamano
2014-02-10 11:04                 ` [PATCH v2 1/2] daemon: move daemonize() to libgit.a Erik Faye-Lund
2014-02-10 18:46                 ` Junio C Hamano
2014-02-10 23:25                   ` Duy Nguyen
2014-02-11 18:08                     ` Junio C Hamano
2014-02-04  8:16       ` bug? git push triggers auto pack when gc.auto = 0 chris
2014-02-04  8:22     ` David Kastrup
2014-02-04  8:59       ` chris
2014-02-04  9:31         ` David Kastrup
2014-02-04 10:35           ` chris
2014-02-04 11:11             ` David Kastrup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqha8eag6c.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jugg@hotmail.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.