From: Junio C Hamano <gitster@pobox.com>
To: "Ravi Mistry via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
Vaidas Pilkauskas <vaidas.pilkauskas@shopify.com>,
Patrick Steinhardt <ps@pks.im>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Ravi Mistry <rmistry@google.com>
Subject: Re: [PATCH v2 3/4] http: add http.retryStatusCodes config option
Date: Tue, 03 Nov 2026 12:56:51 -0800 [thread overview]
Message-ID: <xmqqik2d63cc.fsf@gitster.g> (raw)
In-Reply-To: <6510dddc39ca61fe1ae2f81cb8e7febd5f82d5ca.1793732247.git.gitgitgadget@gmail.com> (Ravi Mistry via GitGitGadget's message of "Tue, 03 Nov 2026 18:57:26 +0000")
"Ravi Mistry via GitGitGadget" <gitgitgadget@gmail.com> writes:
> http.retryAfter::
> Initial wait time in seconds before retrying when a server returns
> - HTTP 429 (Too Many Requests) without a Retry-After header.
> + a retryable HTTP status code without a Retry-After header. The
> + set of retryable status codes is configured by
> + `http.retryStatusCodes`, which includes only HTTP 429 (Too Many
> + Requests) by default.
I as a lazy person would probably have written
... when a server returns a retryable HTTP status code (see
`http.retryStatusCodes`) without a Retry-After header.
and omitted everything else, but this is better by being more self
contained ;-).
Looking good.
By the way, after the dust settles, we should fix the formatting of
these variable name entries wholesale. Looking at a few files in
the same directory, like log.adoc and grep.adoc:
$ git grep -h '^[^ ]*::$' Documentation/config/{log,grep}.adoc
`grep.lineNumber`::
`grep.column`::
`grep.patternType`::
`grep.extendedRegexp`::
`grep.threads`::
`grep.fullName`::
`grep.fallbackToNoIndex`::
`log.abbrevCommit`::
`log.date`::
`log.decorate`::
`log.initialDecorationSet`::
`log.excludeDecoration`::
`log.diffMerges`::
`log.follow`::
`log.graphColors`::
`log.graphIndent`::
`log.showRoot`::
`log.showSignature`::
`log.mailmap`::
these names are supposed to be marked up in certain ways, but none
in this file is.
Anyway, the whole series was a pleasant read. Thanks.
next prev parent reply other threads:[~2026-11-03 20:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 15:57 [PATCH 0/4] http: exponential backoff, configurable status codes, and post_rpc() retries Ravi Mistry via GitGitGadget
2026-10-31 15:57 ` [PATCH 1/4] http: fix retry count and Retry-After timing Ravi Mistry via GitGitGadget
2026-11-03 1:03 ` Junio C Hamano
2026-11-03 19:05 ` Ravi Mistry
2026-10-31 15:57 ` [PATCH 2/4] http: add exponential backoff without Retry-After Ravi Mistry via GitGitGadget
2026-11-03 13:21 ` Junio C Hamano
2026-11-03 19:05 ` Ravi Mistry
2026-10-31 15:57 ` [PATCH 3/4] http: add http.retryStatusCodes config option Ravi Mistry via GitGitGadget
2026-11-03 13:41 ` Junio C Hamano
2026-11-03 19:06 ` Ravi Mistry
2026-10-31 15:57 ` [PATCH 4/4] remote-curl: retry transient HTTP errors in post_rpc() Ravi Mistry via GitGitGadget
2026-11-03 14:47 ` Junio C Hamano
2026-11-03 18:57 ` [PATCH v2 0/4] http: exponential backoff, configurable status codes, and post_rpc() retries Ravi Mistry via GitGitGadget
2026-11-03 18:57 ` [PATCH v2 1/4] http: fix retry count and Retry-After timing Ravi Mistry via GitGitGadget
2026-11-03 18:57 ` [PATCH v2 2/4] http: add exponential backoff without Retry-After Ravi Mistry via GitGitGadget
2026-11-03 18:57 ` [PATCH v2 3/4] http: add http.retryStatusCodes config option Ravi Mistry via GitGitGadget
2026-11-03 20:56 ` Junio C Hamano [this message]
2026-11-03 18:57 ` [PATCH v2 4/4] remote-curl: retry transient HTTP errors in post_rpc() Ravi Mistry via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqik2d63cc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ps@pks.im \
--cc=rmistry@google.com \
--cc=sandals@crustytoothpaste.net \
--cc=vaidas.pilkauskas@shopify.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.