All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Mihai Cosma <mcosma@gmail.com>
Cc: git@vger.kernel.org,  peff@peff.net,  stolee@gmail.com,
	quark.zju@gmail.com
Subject: Re: [PATCH 0/2] status: stop holding index.lock while collecting
Date: Fri, 23 Oct 2026 11:33:12 -0700	[thread overview]
Message-ID: <xmqqik2s5kt3.fsf@gitster.g> (raw)
In-Reply-To: <20261022184420.3648771-1-mcosma@gmail.com> (Mihai Cosma's message of "Thu, 22 Oct 2026 14:44:18 -0400")

Mihai Cosma <mcosma@gmail.com> writes:

> This overlaps with Jun Wu's "Wait for the index lock instead of
> failing" series, and the two fit together: his makes writers wait for
> the lock, this makes status hold it rarely and briefly. They only
> conflict on the one lock call in cmd_status(), which his series renames
> to repo_try_hold_locked_index(). I'm happy to rebase onto it. On top of
> his v2, the slowest "git add" in the clean case below went from 1020 ms
> (one failure at his 1s timeout) to 160 ms.

Perhaps you two can work together and send a single consolidated series?

Thanks.

  parent reply	other threads:[~2026-10-23 18:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 18:44 [PATCH 0/2] status: stop holding index.lock while collecting Mihai Cosma
2026-10-22 18:44 ` [PATCH 1/2] read-cache: verify skipHash index by stat data Mihai Cosma
2026-10-22 18:44 ` [PATCH 2/2] status: lock the index only to write it Mihai Cosma
2026-10-23 18:33 ` Junio C Hamano [this message]
2026-10-23 19:50   ` [PATCH 0/2] status: stop holding index.lock while collecting Jun Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqik2s5kt3.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mcosma@gmail.com \
    --cc=peff@peff.net \
    --cc=quark.zju@gmail.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.