All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Marc Becker via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Marc Becker <becm@gmx.de>
Subject: Re: [PATCH v3] wincred: refactor credential blob processing
Date: Mon, 12 Oct 2026 14:57:08 -0700	[thread overview]
Message-ID: <xmqqik364m6j.fsf@gitster.g> (raw)
In-Reply-To: <pull.2251.v3.git.1791840427937.gitgitgadget@gmail.com> (Marc Becker via GitGitGadget's message of "Mon, 12 Oct 2026 21:27:07 +0000")

"Marc Becker via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Marc Becker <becm@gmx.de>
>
> Invalid target size check (bytes instead of characters) for `wcsncpy_s`
> already led to memory corruption; d22a4884 just hid the error by making
> sure the target is always big enough.

While I can parse each sentence and understand every individual
word, it remains unclear what they are trying to convey in the
context of explaining this change.  In my native tongue, there is a
very appropriate expression to describe such a statement:
言語明瞭意味不明.  It roughly translates to "clear language, obscure
meaning".

I will leave this patch for those who work on Windows to review.

Thanks.

      reply	other threads:[~2026-10-12 21:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09 13:45 [PATCH] wincred: fix line split of secret blob content Marc Becker via GitGitGadget
2026-10-09 21:16 ` Junio C Hamano
2026-10-10 11:47 ` [PATCH v2] wincred: refactor credential blob processing Marc Becker via GitGitGadget
2026-10-12 21:27 ` [PATCH v3] " Marc Becker via GitGitGadget
2026-10-12 21:57   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqik364m6j.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=becm@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.