All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Hardik Kumar <hardikxk@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh
Date: Mon, 31 Aug 2026 15:10:04 -0700	[thread overview]
Message-ID: <xmqqik4quekj.fsf@gitster.g> (raw)
In-Reply-To: <20260901-typo-fix-v3-1-cc342f329190@gmail.com> (Hardik Kumar's message of "Tue, 01 Sep 2026 00:59:13 +0530")

Hardik Kumar <hardikxk@gmail.com> writes:

> The patch fixes two typos in two places.
> versioncmp.c:           "fractionnal" -> "fractional"
> t/t0022-crlf-rename.sh: "similiarity" -> "similarity"
>
> No functional changes, only update a comment and a test_description.
>
> Signed-off-by: Hardik Kumar <hardikxk@gmail.com>
> ---
> Changes in v3:
> - fix file name typo in commit message body
> - Link to v2: https://lore.kernel.org/r/20260901-typo-fix-v2-1-6aeafbae6389@gmail.com

Thanks.  Applied.

>
> Changes in v2:
> - refactor commit message
> - Link to v1: https://lore.kernel.org/r/20260828-typo-fix-v1-1-24e80a87ed53@gmail.com
> ---
>  t/t0022-crlf-rename.sh | 2 +-
>  versioncmp.c           | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh
> index 9bd863a970..328c6e5903 100755
> --- a/t/t0022-crlf-rename.sh
> +++ b/t/t0022-crlf-rename.sh
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  
> -test_description='ignore CR in CRLF sequence while computing similiarity'
> +test_description='ignore CR in CRLF sequence while computing similarity'
>  
>  . ./test-lib.sh
>  
> diff --git a/versioncmp.c b/versioncmp.c
> index 3a81b17bc1..f1e451755a 100644
> --- a/versioncmp.c
> +++ b/versioncmp.c
> @@ -15,7 +15,7 @@
>  
>  /*
>   * states: S_N: normal, S_I: comparing integral part, S_F: comparing
> - * fractionnal parts, S_Z: idem but with leading Zeroes only
> + * fractional parts, S_Z: idem but with leading Zeroes only
>   */
>  #define  S_N    0x0
>  #define  S_I    0x3
>
> ---
> base-commit: f78ce2f7b6df702f93d40b85d6bda92a3f65da79
> change-id: 20260828-typo-fix-721b77177721

      reply	other threads:[~2026-08-31 22:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 19:29 [PATCH v3] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh Hardik Kumar
2026-08-31 22:10 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqik4quekj.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hardikxk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.