All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Karthik Nayak <karthik.188@gmail.com>,
	 Justin Tobler <jltobler@gmail.com>
Subject: Re: [PATCH v3 15/17] odb/source-packed: stub out remaining functions
Date: Thu, 18 Jun 2026 10:59:32 -0700	[thread overview]
Message-ID: <xmqqik7frapn.fsf@gitster.g> (raw)
In-Reply-To: <20260617-pks-odb-source-packed-v3-15-b5c7583cd795@pks.im> (Patrick Steinhardt's message of "Wed, 17 Jun 2026 08:39:58 +0200")

Patrick Steinhardt <ps@pks.im> writes:

Just FYI (i.e. nothing wrong in this patch)

> +static int odb_source_packed_write_object(struct odb_source *source UNUSED,
> +					  const void *buf UNUSED,
> +					  unsigned long len UNUSED,

The type of this parameter will become size_t via another topic in
flight; I prepared an evil merge to address it (otherwise winbuild
would barf, as expected).

-- >8 --
Author: Junio C Hamano <gitster@pobox.com>
Date:   Thu Jun 18 10:49:10 2026 -0700

    merge-fix po/hash-object-size-t vs ps/odb-source-packed

diff --git a/odb/source-packed.c b/odb/source-packed.c
index 42c28fba0e..decc81aa52 100644
--- a/odb/source-packed.c
+++ b/odb/source-packed.c
@@ -503,7 +503,7 @@ static int odb_source_packed_freshen_object(struct odb_source *source,
 
 static int odb_source_packed_write_object(struct odb_source *source UNUSED,
 					  const void *buf UNUSED,
-					  unsigned long len UNUSED,
+					  size_t len UNUSED,
 					  enum object_type type UNUSED,
 					  struct object_id *oid UNUSED,
 					  struct object_id *compat_oid UNUSED,

  reply	other threads:[~2026-06-18 17:59 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 11:25 [PATCH 00/16] odb: make packed object source a proper `struct odb_source` Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 01/16] packfile: rename `struct packfile_store` to `odb_source_packed` Patrick Steinhardt
2026-06-05 14:25   ` Karthik Nayak
2026-06-08  6:23     ` Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 02/16] packfile: move packed source into "odb/" subsystem Patrick Steinhardt
2026-06-08 15:09   ` Karthik Nayak
2026-06-09  7:27     ` Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 03/16] odb/source-packed: store pointer to "files" instead of generic source Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 04/16] odb/source-packed: start converting to a proper `struct odb_source` Patrick Steinhardt
2026-06-08 15:29   ` Karthik Nayak
2026-06-09  7:27     ` Patrick Steinhardt
2026-06-09 10:47       ` Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 05/16] odb/source-packed: wire up `close()` callback Patrick Steinhardt
2026-06-08 15:31   ` Karthik Nayak
2026-06-04 11:25 ` [PATCH 06/16] odb/source-packed: wire up `reprepare()` callback Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 07/16] packfile: use higher-level interface to implement `has_object_pack()` Patrick Steinhardt
2026-06-08 16:07   ` Karthik Nayak
2026-06-04 11:25 ` [PATCH 08/16] odb/source-packed: wire up `read_object_info()` callback Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 09/16] odb/source-packed: wire up `read_object_stream()` callback Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 10/16] odb/source-packed: wire up `for_each_object()` callback Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 11/16] odb/source-packed: wire up `count_objects()` callback Patrick Steinhardt
2026-06-08 16:12   ` Karthik Nayak
2026-06-09  7:27     ` Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 12/16] odb/source-packed: wire up `find_abbrev_len()` callback Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 13/16] odb/source-packed: wire up `freshen_object()` callback Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 14/16] odb/source-packed: stub out remaining functions Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 15/16] midx: refactor interfaces to work on "packed" source Patrick Steinhardt
2026-06-04 11:25 ` [PATCH 16/16] odb/source-packed: drop pointer to "files" parent source Patrick Steinhardt
2026-06-08 16:15 ` [PATCH 00/16] odb: make packed object source a proper `struct odb_source` Karthik Nayak
2026-06-09  7:27   ` Patrick Steinhardt
2026-06-09  8:50 ` [PATCH v2 00/17] " Patrick Steinhardt
2026-06-09  8:50   ` [PATCH v2 01/17] packfile: rename `struct packfile_store` to `odb_source_packed` Patrick Steinhardt
2026-06-16 21:01     ` Justin Tobler
2026-06-09  8:50   ` [PATCH v2 02/17] packfile: split out packfile list logic Patrick Steinhardt
2026-06-09  8:50   ` [PATCH v2 03/17] packfile: move packed source into "odb/" subsystem Patrick Steinhardt
2026-06-09  8:50   ` [PATCH v2 04/17] odb/source-packed: store pointer to "files" instead of generic source Patrick Steinhardt
2026-06-16 21:14     ` Justin Tobler
2026-06-16 21:28       ` Justin Tobler
2026-06-17  7:26       ` Patrick Steinhardt
2026-06-09  8:50   ` [PATCH v2 05/17] odb/source-packed: start converting to a proper `struct odb_source` Patrick Steinhardt
2026-06-16 21:36     ` Justin Tobler
2026-06-17  7:26       ` Patrick Steinhardt
2026-06-09  8:50   ` [PATCH v2 06/17] odb/source-packed: wire up `close()` callback Patrick Steinhardt
2026-06-09  8:51   ` [PATCH v2 07/17] odb/source-packed: wire up `reprepare()` callback Patrick Steinhardt
2026-06-16 21:53     ` Justin Tobler
2026-06-17  7:26       ` Patrick Steinhardt
2026-06-09  8:51   ` [PATCH v2 08/17] packfile: use higher-level interface to implement `has_object_pack()` Patrick Steinhardt
2026-06-09  8:51   ` [PATCH v2 09/17] odb/source-packed: wire up `read_object_info()` callback Patrick Steinhardt
2026-06-09  8:51   ` [PATCH v2 10/17] odb/source-packed: wire up `read_object_stream()` callback Patrick Steinhardt
2026-06-09  8:51   ` [PATCH v2 11/17] odb/source-packed: wire up `for_each_object()` callback Patrick Steinhardt
2026-06-16 22:10     ` Justin Tobler
2026-06-17  7:26       ` Patrick Steinhardt
2026-06-09  8:51   ` [PATCH v2 12/17] odb/source-packed: wire up `count_objects()` callback Patrick Steinhardt
2026-06-09  8:51   ` [PATCH v2 13/17] odb/source-packed: wire up `find_abbrev_len()` callback Patrick Steinhardt
2026-06-09  8:51   ` [PATCH v2 14/17] odb/source-packed: wire up `freshen_object()` callback Patrick Steinhardt
2026-06-09  8:51   ` [PATCH v2 15/17] odb/source-packed: stub out remaining functions Patrick Steinhardt
2026-06-09  8:51   ` [PATCH v2 16/17] midx: refactor interfaces to work on "packed" source Patrick Steinhardt
2026-06-16 22:37     ` Justin Tobler
2026-06-17  7:26       ` Patrick Steinhardt
2026-06-09  8:51   ` [PATCH v2 17/17] odb/source-packed: drop pointer to "files" parent source Patrick Steinhardt
2026-06-16 22:51     ` Justin Tobler
2026-06-17  7:26       ` Patrick Steinhardt
2026-06-17  6:39 ` [PATCH v3 00/17] odb: make packed object source a proper `struct odb_source` Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 01/17] packfile: rename `struct packfile_store` to `odb_source_packed` Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 02/17] packfile: split out packfile list logic Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 03/17] packfile: move packed source into "odb/" subsystem Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 04/17] odb/source-packed: store pointer to "files" instead of generic source Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 05/17] odb/source-packed: start converting to a proper `struct odb_source` Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 06/17] odb/source-packed: wire up `close()` callback Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 07/17] odb/source-packed: wire up `reprepare()` callback Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 08/17] packfile: use higher-level interface to implement `has_object_pack()` Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 09/17] odb/source-packed: wire up `read_object_info()` callback Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 10/17] odb/source-packed: wire up `read_object_stream()` callback Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 11/17] odb/source-packed: wire up `for_each_object()` callback Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 12/17] odb/source-packed: wire up `count_objects()` callback Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 13/17] odb/source-packed: wire up `find_abbrev_len()` callback Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 14/17] odb/source-packed: wire up `freshen_object()` callback Patrick Steinhardt
2026-06-17  6:39   ` [PATCH v3 15/17] odb/source-packed: stub out remaining functions Patrick Steinhardt
2026-06-18 17:59     ` Junio C Hamano [this message]
2026-06-17  6:39   ` [PATCH v3 16/17] midx: refactor interfaces to work on "packed" source Patrick Steinhardt
2026-06-17  6:40   ` [PATCH v3 17/17] odb/source-packed: drop pointer to "files" parent source Patrick Steinhardt
2026-06-17 15:02   ` [PATCH v3 00/17] odb: make packed object source a proper `struct odb_source` Justin Tobler
2026-06-17 16:53     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqik7frapn.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jltobler@gmail.com \
    --cc=karthik.188@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.