From: Junio C Hamano <gitster@pobox.com>
To: "Guillaume Jacob via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Guillaume Jacob <guillaume@absolut-sensing.com>
Subject: Re: [PATCH] doc: fix git grep args order in Quick Reference
Date: Mon, 16 Mar 2026 10:16:52 -0700 [thread overview]
Message-ID: <xmqqikavpud7.fsf@gitster.g> (raw)
In-Reply-To: <pull.2069.git.1773670536808.gitgitgadget@gmail.com> (Guillaume Jacob via GitGitGadget's message of "Mon, 16 Mar 2026 14:15:36 +0000")
"Guillaume Jacob via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Guillaume Jacob <guillaume@absolut-sensing.com>
>
> The example provided has its arguments in the wrong order. The revision
> should follow the pattern, and not the other way around.
Well written. The patch title also comforms our convention.
>
> Signed-off-by: Guillaume Jacob <guillaume@absolut-sensing.com>
> ---
Signed off correctly with the same identity as in-body From: line.
The patch contents also is reasonable.
Will queue. Thanks.
> doc: fix git grep args order in Quick Reference
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2069%2Fguillaume-jcb%2Fdoc-fix-args-order-in-quick-ref-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2069/guillaume-jcb/doc-fix-args-order-in-quick-ref-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/2069
>
> Documentation/user-manual.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/user-manual.adoc b/Documentation/user-manual.adoc
> index 7696987117..64009baf37 100644
> --- a/Documentation/user-manual.adoc
> +++ b/Documentation/user-manual.adoc
> @@ -4466,7 +4466,7 @@ $ git show # most recent commit
> $ git diff v2.6.15..v2.6.16 # diff between two tagged versions
> $ git diff v2.6.15..HEAD # diff with current head
> $ git grep "foo()" # search working directory for "foo()"
> -$ git grep v2.6.15 "foo()" # search old tree for "foo()"
> +$ git grep "foo()" v2.6.15 # search old tree for "foo()"
> $ git show v2.6.15:a.txt # look at old version of a.txt
> -----------------------------------------------
>
>
> base-commit: dc6ecd5354dca88d51b6d6562777fc8fc10d77e1
prev parent reply other threads:[~2026-03-16 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 14:15 [PATCH] doc: fix git grep args order in Quick Reference Guillaume Jacob via GitGitGadget
2026-03-16 17:16 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqikavpud7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=guillaume@absolut-sensing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.