From: Junio C Hamano <gitster@pobox.com>
To: Bello Olamide <belkid98@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git@vger.kernel.org, usmanakinyemi202@gmail.com,
kristofferhaugsbakk@fastmail.com
Subject: Re: [Outreachy PATCH v4 0/2] do not use strbuf_split*()
Date: Tue, 21 Oct 2025 10:13:20 -0700 [thread overview]
Message-ID: <xmqqikg8w53j.fsf@gitster.g> (raw)
In-Reply-To: <CAD=f0L-9e0uYv-T6HYkCFAWPa57y44PXV0Xi8S5MfHQVgnYUAw@mail.gmail.com> (Bello Olamide's message of "Tue, 21 Oct 2025 11:19:53 +0100")
Bello Olamide <belkid98@gmail.com> writes:
>> > Commit 2efe707054 (wt-status: avoid strbuf_split*(), 2025-07-31) for example,
>> > in the series, notes that abbrev_oid_in_line() takes one line of rebase
>> > todo list and splits tokens out of this line using strbuf_split_max().
>> > However, no simultanous edits that take advantage of the strbuf API take
>> > place but the tokens are merely used as pieces of strings.
>>
>> I am not sure taking this commit as an example is really useful now
>> that the string_list_split*() functions are not used in your series
>> anymore. Maybe you can find a more relevant example commit in Junio's
>> series?
>>
>> [...]
>
> Okay. Thank you. I will take a closer look at the series and look for
> a more suitable
> reference.
Thanks Christian for lending us very sharp eyes.
What we do in these patches now is closer in spirit to d6fd08bd
(sub-process: do not use strbuf_split*(), 2025-07-31), I think, in
that we do not split things into an array of strbuf, and instead
parse things out in place as much as possible.
next prev parent reply other threads:[~2025-10-21 17:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 22:55 [Outreachy PATCH v4 0/2] do not use strbuf_split*() Olamide Caleb Bello
2025-10-20 22:55 ` [Outreachy PATCH v4 1/2] gpg-interface: do not use misdesigned strbuf_split*() Olamide Caleb Bello
2025-10-21 6:46 ` Christian Couder
2025-10-21 6:51 ` Christian Couder
2025-10-21 11:18 ` Bello Olamide
2025-10-21 16:26 ` Junio C Hamano
2025-10-20 22:55 ` [Outreachy PATCH v4 2/2] gpg-interface: do not use misdesigned strbuf_split*() [Part 2] Olamide Caleb Bello
2025-10-21 7:01 ` Christian Couder
2025-10-21 12:12 ` Bello Olamide
2025-10-21 7:19 ` [Outreachy PATCH v4 0/2] do not use strbuf_split*() Christian Couder
2025-10-21 10:19 ` Bello Olamide
2025-10-21 17:13 ` Junio C Hamano [this message]
2025-10-22 7:16 ` Bello Olamide
2025-10-22 12:40 ` [Outreachy PATCH v5 0/2] do not use misdesigned strbuf_split*() Olamide Caleb Bello
2025-10-22 12:40 ` [Outreachy PATCH v5 1/2] gpg-interface: " Olamide Caleb Bello
2025-10-22 13:56 ` Christian Couder
2025-10-23 8:14 ` Bello Olamide
2025-10-22 12:40 ` [Outreachy PATCH v5 2/2] " Olamide Caleb Bello
2025-10-22 14:03 ` Christian Couder
2025-10-22 17:44 ` Junio C Hamano
2025-10-23 8:17 ` Bello Olamide
2025-10-23 11:13 ` [Outreachy PATCH v6 0/2] " Olamide Caleb Bello
2025-10-23 11:13 ` [Outreachy PATCH v6 1/2] gpg-interface: " Olamide Caleb Bello
2025-10-23 11:13 ` [Outreachy PATCH v6 2/2] " Olamide Caleb Bello
2025-10-23 16:27 ` [Outreachy PATCH v6 0/2] " Junio C Hamano
2025-10-24 13:25 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqikg8w53j.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=belkid98@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.