All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Justin Tobler <jltobler@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
	 git@vger.kernel.org,
	 Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	 Phillip Wood <phillip.wood123@gmail.com>
Subject: Re: [PATCH v3 0/4] Build improvements for clar
Date: Wed, 20 Nov 2024 10:24:11 +0900	[thread overview]
Message-ID: <xmqqiksiae9w.fsf@gitster.g> (raw)
In-Reply-To: <7jdpmcwlxtyzqrqmcftcdmrw3tqopawtuuzqf3uaff2gklaxba@covcdisniubk> (Justin Tobler's message of "Tue, 19 Nov 2024 10:51:03 -0600")

Justin Tobler <jltobler@gmail.com> writes:

> On 24/11/15 08:32AM, Patrick Steinhardt wrote:
>> Hi,
>> 
>> Dscho has reported in [1] that the CMake build instructions for clar do
>> not work well on Windows/MSVC because we execute the shell scripts
>> directly instead of using the discovered `SH_EXE`. This small patch
>> series fixes the issue.
>> 
>> Changes in v2:
>> 
>>     - Wrap overly long lines in the CMake build instructions.
>>     - Add the VERBATIM option.
>> 
>> Changes in v3:
>> 
>>     - Fix missing word.
>> 
>> Link to v1: https://lore.kernel.org/r/20241108-pks-clar-build-improvements-v1-0-25c1fe65ce37@pks.im
>> Link to v2: https://lore.kernel.org/r/20241111-pks-clar-build-improvements-v2-0-d4794d8d1b30@pks.im
>> 
>> Thanks!
>> 
>> Patrick
>
> I've reviewed this series and overall this version looks good to me.
> Embedding the awk script in the shell script and changing how the
> scripts get executed to address platform related build issues seems
> sensable to me.

Thanks, both.  Let's merge it down to 'next'.


      reply	other threads:[~2024-11-20  1:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08 13:16 [PATCH 0/3] Build improvements for clar Patrick Steinhardt
2024-11-08 13:16 ` [PATCH 1/3] t/unit-tests: convert "clar-generate.awk" into a shell script Patrick Steinhardt
2024-11-08 13:16 ` [PATCH 2/3] cmake: use SH_EXE to execute clar scripts Patrick Steinhardt
2024-11-08 13:16 ` [PATCH 3/3] Makefile: let clar header targets depend on their scripts Patrick Steinhardt
2024-11-10 14:30 ` [PATCH 0/3] Build improvements for clar Phillip Wood
2024-11-11  1:34   ` Junio C Hamano
2024-11-11  8:29     ` Patrick Steinhardt
2024-11-11 22:52       ` Junio C Hamano
2024-11-11  8:24 ` [PATCH v2 0/4] " Patrick Steinhardt
2024-11-11  8:24   ` [PATCH v2 1/4] t/unit-tests: convert "clar-generate.awk" into a shell script Patrick Steinhardt
2024-11-11 22:58     ` Junio C Hamano
2024-11-12  5:56       ` Patrick Steinhardt
2024-11-11  8:24   ` [PATCH v2 2/4] cmake: use SH_EXE to execute clar scripts Patrick Steinhardt
2024-11-11  8:24   ` [PATCH v2 3/4] cmake: use verbatim arguments when invoking clar commands Patrick Steinhardt
2024-11-13 15:41     ` Johannes Schindelin
2024-11-14 10:28       ` Phillip Wood
2024-11-11  8:25   ` [PATCH v2 4/4] Makefile: let clar header targets depend on their scripts Patrick Steinhardt
2024-11-11 10:09   ` [PATCH v2 0/4] Build improvements for clar Phillip Wood
2024-11-15  7:32 ` [PATCH v3 " Patrick Steinhardt
2024-11-15  7:32   ` [PATCH v3 1/4] t/unit-tests: convert "clar-generate.awk" into a shell script Patrick Steinhardt
2024-11-15  7:32   ` [PATCH v3 2/4] cmake: use SH_EXE to execute clar scripts Patrick Steinhardt
2024-11-18 18:47     ` Justin Tobler
2024-11-19  6:13       ` Patrick Steinhardt
2024-11-15  7:32   ` [PATCH v3 3/4] cmake: use verbatim arguments when invoking clar commands Patrick Steinhardt
2024-11-15  7:32   ` [PATCH v3 4/4] Makefile: let clar header targets depend on their scripts Patrick Steinhardt
2024-11-19 16:51   ` [PATCH v3 0/4] Build improvements for clar Justin Tobler
2024-11-20  1:24     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqiksiae9w.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jltobler@gmail.com \
    --cc=phillip.wood123@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.