All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Koji Nakamaru <koji.nakamaru@gree.net>,
	Ramsay Jones <ramsay@ramsayjones.plus.com>
Subject: Re: [PATCH v4] fsmonitor OSX: fix hangs for submodules
Date: Fri, 04 Oct 2024 10:44:32 -0700	[thread overview]
Message-ID: <xmqqiku7epa7.fsf@gitster.g> (raw)
In-Reply-To: <pull.1802.v4.git.1728000433326.gitgitgadget@gmail.com> (Koji Nakamaru via GitGitGadget's message of "Fri, 04 Oct 2024 00:07:13 +0000")

"Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail.com> writes:

> ... The test is
> disabled for MINGW because hangs treated with this patch occur only for
> Darwin and there is no simple way to terminate the win32 fsmonitor
> daemon that hangs.
> ...
>      @@ t/t7527-builtin-fsmonitor.sh: test_expect_success "submodule absorbgitdirs impli
>       +	done
>       +}
>       +
>      -+test_expect_success "submodule implicitly starts daemon by pull" '
>      ++test_expect_success !MINGW "submodule implicitly starts daemon by pull" '
>       +	test_atexit "stop_watchdog" &&
>       +	test_when_finished "stop_git; rm -rf cloned super sub" &&
>       +

Let me update !MINGW to !WINDOWS while queuing.

  reply	other threads:[~2024-10-04 17:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-29  2:41 [PATCH] fsmonitor OSX: fix hangs for submodules Koji Nakamaru via GitGitGadget
2024-09-30 17:40 ` Junio C Hamano
2024-10-01  4:11   ` Koji Nakamaru
2024-10-01  5:09 ` [PATCH v2] " Koji Nakamaru via GitGitGadget
2024-10-01 11:57   ` Junio C Hamano
2024-10-01 17:51     ` Koji Nakamaru
2024-10-01 18:04       ` Junio C Hamano
2024-10-01 18:42         ` Koji Nakamaru
2024-10-02  6:58           ` Koji Nakamaru
2024-10-02 18:14             ` Junio C Hamano
2024-10-03  8:54               ` Koji Nakamaru
2024-10-03 17:44                 ` Junio C Hamano
2024-10-04  2:42                   ` Koji Nakamaru
2024-10-01 19:29   ` [PATCH v3] " Koji Nakamaru via GitGitGadget
2024-10-04  0:07     ` [PATCH v4] " Koji Nakamaru via GitGitGadget
2024-10-04 17:44       ` Junio C Hamano [this message]
2024-10-04 18:47         ` Ramsay Jones
2024-10-04 19:07           ` Junio C Hamano
2024-10-05  3:12         ` Koji Nakamaru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqiku7epa7.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=koji.nakamaru@gree.net \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.