All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Chandra Pratap <chandrapratap3519@gmail.com>
Cc: git@vger.kernel.org,  karthik188@gmail.com,  chriscool@tuxfamily.org
Subject: Re: [PATCH v5 2/5] t: move reftable/tree_test.c to the unit testing framework
Date: Mon, 22 Jul 2024 10:52:15 -0700	[thread overview]
Message-ID: <xmqqikwxco1c.fsf@gitster.g> (raw)
In-Reply-To: <20240722061836.4176-3-chandrapratap3519@gmail.com> (Chandra Pratap's message of "Mon, 22 Jul 2024 11:27:55 +0530")

Chandra Pratap <chandrapratap3519@gmail.com> writes:

> reftable/tree_test.c exercises the functions defined in
> reftable/tree.{c, h}. Migrate reftable/tree_test.c to the unit
> testing framework. Migration involves refactoring the tests to use
> the unit testing framework instead of reftable's test framework and
> renaming the tests to align with unit-tests' standards.
>
> Also add a comment to help understand the test routine.
>
> Note that this commit mostly moves the test from reftable/ to
> t/unit-tests/ and most of the refactoring is performed by the
> trailing commits.
>
> Mentored-by: Patrick Steinhardt <ps@pks.im>
> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
> ---

Looking good.

"git show -M30" matches the moved file up correctly and makes it
easy to see that there is no serious changes snuck in (please do not
take this as a suggestion to run format-patch with -M30---I am just
saying that it was a good way to give an extra validation).

Thanks.

  reply	other threads:[~2024-07-22 17:52 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 13:01 [GSoC][PATCH 0/4] t: port reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-06-10 13:01 ` [PATCH 1/4] reftable: remove unnecessary curly braces in reftable/tree.c Chandra Pratap
2024-06-10 13:01 ` [PATCH 2/4] t: move reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-06-10 13:01 ` [PATCH 3/4] t-reftable-tree: split test_tree() into two sub-test functions Chandra Pratap
2024-06-10 13:49   ` Patrick Steinhardt
2024-06-11  6:44     ` Chandra Pratap
2024-06-10 13:01 ` [PATCH 4/4] t-reftable-tree: add test for non-existent key Chandra Pratap
2024-06-12  5:38 ` [GSoC][PATCH v2 0/5] t: port reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-06-12  5:38   ` [PATCH v2 1/5] reftable: remove unnecessary curly braces in reftable/tree.c Chandra Pratap
2024-06-12  5:38   ` [PATCH v2 2/5] t: move reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-06-12  5:38   ` [PATCH v2 3/5] t-reftable-tree: split test_tree() into two sub-test functions Chandra Pratap
2024-06-12  5:38   ` [PATCH v2 4/5] t-reftable-tree: add test for non-existent key Chandra Pratap
2024-06-12  5:38   ` [PATCH v2 5/5] t-reftable-tree: improve the test for infix_walk() Chandra Pratap
2024-06-12  6:59     ` Patrick Steinhardt
2024-06-12  9:05       ` Chandra Pratap
2024-06-12 12:52   ` [GSoC][PATCH v3 0/5] t: port reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-06-12 12:52     ` [PATCH v3 1/5] reftable: remove unnecessary curly braces in reftable/tree.c Chandra Pratap
2024-06-12 12:53     ` [PATCH v3 2/5] t: move reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-06-12 12:53     ` [PATCH v3 3/5] t-reftable-tree: split test_tree() into two sub-test functions Chandra Pratap
2024-06-12 12:53     ` [PATCH v3 4/5] t-reftable-tree: add test for non-existent key Chandra Pratap
2024-06-12 12:53     ` [PATCH v3 5/5] t-reftable-tree: improve the test for infix_walk() Chandra Pratap
2024-07-16  7:48     ` [GSoC][PATCH v4 0/5] t: port reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-07-16  7:48       ` [PATCH v4 1/5] reftable: remove unnecessary curly braces in reftable/tree.c Chandra Pratap
2024-07-16  7:48       ` [PATCH v4 2/5] t: move reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-07-17 11:49         ` Karthik Nayak
2024-07-17 13:50           ` Chandra Pratap
2024-07-18  8:04             ` Karthik Nayak
2024-07-17 12:39         ` Karthik Nayak
2024-07-17 14:30           ` Chandra Pratap
2024-07-17 22:14             ` Justin Tobler
2024-07-18  4:58               ` Chandra Pratap
2024-07-18  8:10                 ` Karthik Nayak
2024-07-18  8:23                   ` Chandra Pratap
2024-07-18 15:26                   ` Justin Tobler
2024-07-16  7:48       ` [PATCH v4 3/5] t-reftable-tree: split test_tree() into two sub-test functions Chandra Pratap
2024-07-16  7:48       ` [PATCH v4 4/5] t-reftable-tree: add test for non-existent key Chandra Pratap
2024-07-16  7:48       ` [PATCH v4 5/5] t-reftable-tree: improve the test for infix_walk() Chandra Pratap
2024-07-16 19:52       ` [GSoC][PATCH v4 0/5] t: port reftable/tree_test.c to the unit testing framework Junio C Hamano
2024-07-22  5:57       ` [GSoC][PATCH v5 " Chandra Pratap
2024-07-22  5:57         ` [PATCH v5 1/5] reftable: remove unnecessary curly braces in reftable/tree.c Chandra Pratap
2024-07-22  5:57         ` [PATCH v5 2/5] t: move reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-07-22 17:52           ` Junio C Hamano [this message]
2024-07-22 17:52           ` Junio C Hamano
2024-07-22 17:56             ` Junio C Hamano
2024-07-22  5:57         ` [PATCH v5 3/5] t-reftable-tree: split test_tree() into two sub-test functions Chandra Pratap
2024-07-22  5:57         ` [PATCH v5 4/5] t-reftable-tree: add test for non-existent key Chandra Pratap
2024-07-22  5:57         ` [PATCH v5 5/5] t-reftable-tree: improve the test for infix_walk() Chandra Pratap
2024-08-01 11:21         ` [GSoC][PATCH v5 0/5] t: port reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-08-01 11:45           ` Patrick Steinhardt
2024-08-02 12:08         ` [GSoC][PATCH v6 " Chandra Pratap
2024-08-02 12:08           ` [PATCH v6 1/5] reftable: remove unnecessary curly braces in reftable/tree.c Chandra Pratap
2024-08-02 12:08           ` [PATCH v6 2/5] t: move reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-08-02 12:08           ` [PATCH v6 3/5] t-reftable-tree: split test_tree() into two sub-test functions Chandra Pratap
2024-08-02 16:25             ` Junio C Hamano
2024-08-02 12:08           ` [PATCH v6 4/5] t-reftable-tree: add test for non-existent key Chandra Pratap
2024-08-02 12:08           ` [PATCH v6 5/5] t-reftable-tree: improve the test for infix_walk() Chandra Pratap
2024-08-04 14:06           ` [GSoC][PATCH v7 0/5] t: port reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-08-04 14:06             ` [PATCH v7 1/5] reftable: remove unnecessary curly braces in reftable/tree.c Chandra Pratap
2024-08-04 14:06             ` [PATCH v7 2/5] t: move reftable/tree_test.c to the unit testing framework Chandra Pratap
2024-08-04 14:06             ` [PATCH v7 3/5] t-reftable-tree: split test_tree() into two sub-test functions Chandra Pratap
2024-08-04 14:06             ` [PATCH v7 4/5] t-reftable-tree: add test for non-existent key Chandra Pratap
2024-08-04 14:06             ` [PATCH v7 5/5] t-reftable-tree: improve the test for infix_walk() Chandra Pratap
2024-08-05 11:04             ` [GSoC][PATCH v7 0/5] t: port reftable/tree_test.c to the unit testing framework Patrick Steinhardt
2024-08-05 15:53               ` Junio C Hamano
2024-08-06  6:30                 ` Patrick Steinhardt
2024-08-06 15:35                   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqikwxco1c.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chandrapratap3519@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=karthik188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.