From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] dir.c: skip .gitignore, etc larger than INT_MAX
Date: Tue, 04 Jun 2024 10:45:04 -0700 [thread overview]
Message-ID: <xmqqikyowqjj.fsf@gitster.g> (raw)
In-Reply-To: <20240604103947.GC1781455@coredump.intra.peff.net> (Jeff King's message of "Tue, 4 Jun 2024 06:39:47 -0400")
Jeff King <peff@peff.net> writes:
> I was hoping to avoid making up an arbitrary number. But your question
> about gitattributes reminded me that we already did something similar in
> 3c50032ff5 (attr: ignore overly large gitattributes files, 2022-12-01).
> There it's a hard-coded 100MB limit (without even a config option).
>
> Maybe we should just do the same here?
Hmph, I thought the 100MB was only for blobs, as we stream the input
we read from a regular file, but we do have the same limit there
presumably to match what we do to blobs? I do not mind that, but I
do not mind leaving it a future "consolidate various size limits on
control files used by Git" patch, that unifies the limit for attrs,
excludes, gitmodules, .git/config, etc.
next prev parent reply other threads:[~2024-06-04 17:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 12:00 [PATCH] dir.c: skip .gitignore, etc larger than INT_MAX Jeff King
2024-05-31 15:05 ` Junio C Hamano
2024-06-04 10:39 ` Jeff King
2024-06-04 17:45 ` Junio C Hamano [this message]
2024-06-05 8:03 ` Jeff King
2024-06-05 16:23 ` Junio C Hamano
2024-05-31 15:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqikyowqjj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.