From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: "Jun. T" <takimoto-j@kba.biglobe.ne.jp>, git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] macOS: ls-files path fails if path of workdir is NFD
Date: Mon, 20 May 2024 11:08:43 -0700 [thread overview]
Message-ID: <xmqqikz8gxuc.fsf@gitster.g> (raw)
In-Reply-To: <20240520160601.GA29154@tb-raspi4> ("Torsten Bögershausen"'s message of "Mon, 20 May 2024 18:06:01 +0200")
Torsten Bögershausen <tboegi@web.de> writes:
> Thanks so much for the detailed analysis, that is appreciated.
> To be honest, I have set core.precomposeunicode true globally,
> ...
> ...
> I am happy to provide a patch (a new testcase is already there),
> but for a change in the codebase I would need some help from an expert,
> to get the config-reading right both for hash_initialized
> (that is may be not about the hash-algorithn at all ?)
> and precompose.
It does not sound like an issue with the hash algorithm.
Why isn't the local config (presumably set with auto-probing when
the repository was initialized) being read? Are we reading the
core.precomposeunicode in some funny ways? Is per-worktree config
involved that is trying to read from one but the auto-probing code
is setting it to another, or something silly like that?
Thanks for working well together, both of you.
next prev parent reply other threads:[~2024-05-20 18:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240430032717281.IXLP.121462.mail.biglobe.ne.jp@biglobe.ne.jp>
2024-05-07 8:44 ` [PATCH v1 1/2] t0050: ls-files path fails if path of workdir is NFD tboegi
2024-05-07 17:30 ` Junio C Hamano
2024-05-07 8:44 ` [PATCH v1 2/2] strbuf_getcwd() needs precompse_strbuf_if_needed() tboegi
2024-05-07 17:22 ` Junio C Hamano
2024-05-09 15:24 ` Junio C Hamano
2024-05-09 15:29 ` Torsten Bögershausen
2024-05-07 17:47 ` Junio C Hamano
2024-05-08 0:32 ` brian m. carlson
2024-05-09 16:11 ` [PATCH v2 1/1] macOS: ls-files path fails if path of workdir is NFD tboegi
2024-05-09 16:37 ` Junio C Hamano
2024-05-19 7:03 ` Jun. T
2024-05-20 16:06 ` Torsten Bögershausen
2024-05-20 18:08 ` Junio C Hamano [this message]
2024-05-20 19:21 ` Torsten Bögershausen
2024-05-21 14:14 ` [PATCH v3 " tboegi
2024-05-21 17:50 ` Junio C Hamano
2024-05-21 20:57 ` Torsten Bögershausen
2024-05-21 22:15 ` Junio C Hamano
2024-05-23 15:33 ` Jun. T
2024-05-25 20:01 ` Torsten Bögershausen
2024-05-31 19:31 ` [PATCH v4 " tboegi
2024-06-01 15:55 ` Junio C Hamano
2024-06-02 19:40 ` Torsten Bögershausen
2024-06-04 0:56 ` Jun T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqikz8gxuc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.