All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <git@matthieu-moy.fr>
Cc: Britton Kerin <britton.kerin@gmail.com>,
	 git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: Re* [BUG] git-bisect man page description of terms command doesn't mention old/new support
Date: Mon, 11 Dec 2023 07:05:17 -0800	[thread overview]
Message-ID: <xmqqil54vkya.fsf@gitster.g> (raw)
In-Reply-To: <24a42fa6-7bc4-4a3b-8bf4-a0ef85dc457a@matthieu-moy.fr> (Matthieu Moy's message of "Mon, 11 Dec 2023 13:34:05 +0100")

Matthieu Moy <git@matthieu-moy.fr> writes:

> Nit: just above we have the description for `bisect start` saying:
>
> --term-{new,bad}=<term> --term-{old,good}=<term>
>
> it probably makes sense to make both homogeneous (start with the same
> alternative, and make the {...,...} vs (...|...) notations
> consistent. The (...|...) notation seems the most common).

Thanks for noticing; I think it has already been fixed a few months
ago, but apparently what I sent predates 3f02785d (doc/git-bisect:
clarify `git bisect run` syntax, 2023-10-23).  So when the patch
gets merged, it will fix itself ;-)

> In any case, the patch looks good to me, thanks.

Thanks.

  reply	other threads:[~2023-12-11 15:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-09 11:58 [BUG] git-bisect man page description of terms command doesn't mention old/new support Britton Kerin
2023-12-09 16:13 ` Re* " Junio C Hamano
2023-12-11 12:34   ` Matthieu Moy
2023-12-11 15:05     ` Junio C Hamano [this message]
2024-02-07 21:44     ` [PATCH 0/2] minute "git bisect" doc updates Junio C Hamano
2024-02-07 21:44       ` [PATCH 1/2] bisect: document "terms" subcommand more fully Junio C Hamano
2024-02-08  6:36         ` Kristoffer Haugsbakk
2024-02-08 16:48           ` Junio C Hamano
2024-02-07 21:44       ` [PATCH 2/2] bisect: document command line arguments for "bisect start" Junio C Hamano
2024-02-08 16:18         ` Jean-Noël Avila
2024-02-09  9:39       ` [PATCH 0/2] minute "git bisect" doc updates Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqil54vkya.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=britton.kerin@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@matthieu-moy.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.