All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Joachim B Haga via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Joachim B Haga <jobh@simula.no>
Subject: Re: [PATCH] gitk: add setting to hide unknown refs
Date: Sat, 09 Dec 2023 06:13:07 +0900	[thread overview]
Message-ID: <xmqqil581jq4.fsf@gitster.g> (raw)
In-Reply-To: <pull.1619.git.1701695899635.gitgitgadget@gmail.com> (Joachim B. Haga via GitGitGadget's message of "Mon, 04 Dec 2023 13:18:19 +0000")

"Joachim B Haga via GitGitGadget" <gitgitgadget@gmail.com> writes:

> This patch adds a setting to gitk to exclude all unknown refs - which
> is considerably simpler than trying to honour the `excludeDecoration`
> pattern.

"This was simpler to implement" is a one-time cost savings for the
developer who added the feature.  For that one-time cost savings,
all the current and future users will pay the price of inconsistent
behaviour between "gitk" and "git log".

It does not look like a good trade-off.

      reply	other threads:[~2023-12-08 21:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04 13:18 [PATCH] gitk: add setting to hide unknown refs Joachim B Haga via GitGitGadget
2023-12-08 21:13 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqil581jq4.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jobh@simula.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.