From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH v3 1/2] "lib-diff" tests: make "README" and "COPYING" test data smaller
Date: Fri, 15 Oct 2021 09:36:09 -0700 [thread overview]
Message-ID: <xmqqilxy8cue.fsf@gitster.g> (raw)
In-Reply-To: <patch-v3-1.2-02342124582-20211015T092605Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 15 Oct 2021 11:30:16 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> t/.gitattributes | 1 -
> t/lib-diff-data.sh | 22 +++
> t/lib-diff.sh | 2 +
> t/lib-diff/COPYING | 361 ----------------------------------
> t/lib-diff/README | 46 -----
> t/t4003-diff-rename-1.sh | 4 +-
> t/t4005-diff-rename-2.sh | 4 +-
> t/t4007-rename-3.sh | 5 +-
> t/t4008-diff-break-rewrite.sh | 4 +-
> t/t4009-diff-rename-4.sh | 4 +-
> 10 files changed, 34 insertions(+), 419 deletions(-)
> create mode 100644 t/lib-diff-data.sh
> delete mode 100644 t/lib-diff/COPYING
> delete mode 100644 t/lib-diff/README
Good. Directly borrowing a test material from the source directory
was an easy hack that worked for us for a reasonably long time, but
when it started to become a maintenance burden, we should have done
something like this, instead of applying the same kind of laziness
when 459b8d22 (tests: do not borrow from COPYING and README from the
real source, 2015-02-15) tried to correct the mess that was caused
by earlier laziness.
Thanks.
next prev parent reply other threads:[~2021-10-15 16:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 9:19 [PATCH 0/5] COPYING: modernize, steal boilerplate from linux.git Ævar Arnfjörð Bjarmason
2021-10-02 9:19 ` [PATCH 1/5] "lib-diff" tests: make "README" and "COPYING" test data smaller Ævar Arnfjörð Bjarmason
2021-10-04 16:46 ` Han-Wen Nienhuys
2021-10-04 17:59 ` Ævar Arnfjörð Bjarmason
2021-10-02 9:19 ` [PATCH 2/5] tests: stop using top-level "README" and "COPYING" files Ævar Arnfjörð Bjarmason
2021-10-02 9:19 ` [PATCH 3/5] COPYING: remove mention of GPLv3, clarify sub-project COPYING Ævar Arnfjörð Bjarmason
2021-10-04 6:21 ` Junio C Hamano
2021-10-02 9:19 ` [PATCH 4/5] COPYING: move GPL text to a "GPL-2.0" file Ævar Arnfjörð Bjarmason
2021-10-02 9:19 ` [PATCH 5/5] GPL-2.0: update to byte-for-byte match the FSF's version Ævar Arnfjörð Bjarmason
2021-10-04 17:28 ` [PATCH 0/5] COPYING: modernize, steal boilerplate from linux.git Han-Wen Nienhuys
2021-10-05 17:01 ` [PATCH v2 " Ævar Arnfjörð Bjarmason
2021-10-05 17:01 ` [PATCH v2 1/5] "lib-diff" tests: make "README" and "COPYING" test data smaller Ævar Arnfjörð Bjarmason
2021-10-05 17:01 ` [PATCH v2 2/5] tests: stop using top-level "README" and "COPYING" files Ævar Arnfjörð Bjarmason
2021-10-05 17:01 ` [PATCH v2 3/5] COPYING: remove mention of GPLv3, clarify sub-project COPYING Ævar Arnfjörð Bjarmason
2021-10-05 17:01 ` [PATCH v2 4/5] COPYING: move GPL text to a "GPL-2.0" file Ævar Arnfjörð Bjarmason
2021-10-05 17:01 ` [PATCH v2 5/5] GPL-2.0: update to byte-for-byte match the FSF's version Ævar Arnfjörð Bjarmason
2021-10-15 9:30 ` [PATCH v3 0/2] tests: stop relying on top-level COPYING and README Ævar Arnfjörð Bjarmason
2021-10-15 9:30 ` [PATCH v3 1/2] "lib-diff" tests: make "README" and "COPYING" test data smaller Ævar Arnfjörð Bjarmason
2021-10-15 16:36 ` Junio C Hamano [this message]
2021-10-15 9:30 ` [PATCH v3 2/2] tests: stop using top-level "README" and "COPYING" files Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilxy8cue.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.