From: Junio C Hamano <gitster@pobox.com>
To: Jacob Vosmaer <jacob@gitlab.com>
Cc: peff@peff.net, me@ttaylorr.com, git@vger.kernel.org, ps@pks.im
Subject: Re: [PATCH 1/2] pkt-line: add packet_fwrite
Date: Thu, 26 Aug 2021 09:33:38 -0700 [thread overview]
Message-ID: <xmqqilzsf9nh.fsf@gitster.g> (raw)
In-Reply-To: 20210826100648.10333-1-jacob@gitlab.com
Jacob Vosmaer <jacob@gitlab.com> writes:
> This adds a new function packet_fwrite which works like packet_write,
> except it writes to a stdio stream.
>
> Helped-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Jacob Vosmaer <jacob@gitlab.com>
> ---
> cache.h | 1 +
> pkt-line.c | 16 ++++++++++++++++
> pkt-line.h | 1 +
> write-or-die.c | 6 ++++++
> 4 files changed, 24 insertions(+)
I wonder if our readers are all proficient enough not to require
some comment to warn them about the care that must be taken when
packet_fwrite() and packet_write() are mixed together (i.e. stdio
flushing, etc.), but other than that, this sounds quite
straight-forward.
prev parent reply other threads:[~2021-08-26 16:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 14:02 [PATCH 1/1] upload-pack: buffer ref advertisement writes Jacob Vosmaer
2021-08-24 21:07 ` Taylor Blau
2021-08-24 21:42 ` Junio C Hamano
2021-08-25 0:44 ` Jeff King
2021-08-26 10:02 ` Jacob Vosmaer
2021-08-26 10:06 ` [PATCH 1/2] pkt-line: add packet_fwrite Jacob Vosmaer
2021-08-26 10:06 ` [PATCH 2/2] upload-pack: use stdio in send_ref callbacks Jacob Vosmaer
2021-08-26 16:33 ` Junio C Hamano
2021-08-26 20:21 ` Junio C Hamano
2021-08-26 22:35 ` Taylor Blau
2021-08-26 23:24 ` Jeff King
2021-08-27 16:15 ` Junio C Hamano
2021-08-31 9:34 ` [PATCH v3 0/2] send_ref buffering Jacob Vosmaer
2021-08-31 9:34 ` [PATCH v3 1/2] pkt-line: add stdio packet write functions Jacob Vosmaer
2021-08-31 10:37 ` Jeff King
2021-08-31 18:13 ` Junio C Hamano
2021-09-01 12:54 ` [PATCH v4 0/2] send_ref buffering Jacob Vosmaer
2021-09-01 12:54 ` [PATCH v4 1/2] pkt-line: add stdio packet write functions Jacob Vosmaer
2021-09-01 12:54 ` [PATCH v4 2/2] upload-pack: use stdio in send_ref callbacks Jacob Vosmaer
2021-09-02 9:18 ` [PATCH v4 0/2] send_ref buffering Jeff King
2021-08-31 9:34 ` [PATCH v3 2/2] upload-pack: use stdio in send_ref callbacks Jacob Vosmaer
2021-08-31 10:25 ` [PATCH v3 0/2] send_ref buffering Jeff King
2021-08-31 13:08 ` Jacob Vosmaer
2021-08-31 17:44 ` Jacob Vosmaer
2021-09-01 0:15 ` Jeff King
2021-08-26 23:32 ` [PATCH 2/2] upload-pack: use stdio in send_ref callbacks Jeff King
2021-08-26 16:33 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilzsf9nh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob@gitlab.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.