From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>, git <git@vger.kernel.org>,
Christian Couder <chriscool@tuxfamily.org>,
Pranit Bauva <pranit.bauva@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Ramsay Jones <ramsay@ramsayjones.plus.com>,
Trygve Aaberge <trygveaa@gmail.com>
Subject: Re: [PATCH v4] t6030: add test for git bisect skip started with --term* arguments
Date: Thu, 29 Apr 2021 17:20:26 +0900 [thread overview]
Message-ID: <xmqqim45h585.fsf@gitster.g> (raw)
In-Reply-To: <CAP8UFD23Wvm-SpoAoFZZWXfXO_KGPdT5vwa4gWXMbtgL66me=w@mail.gmail.com> (Christian Couder's message of "Thu, 29 Apr 2021 10:05:11 +0200")
Christian Couder <christian.couder@gmail.com> writes:
> I am not sure how safe it is to use the hash of a commit that is in
> seen but not yet in next. I suggested using "a previous commit"
> instead as I thought that both the fix and this commit should be part
> of the same branch, and then it would be obvious which commit it is.
> Maybe we should wait for Junio to come back from vacation and decide
> about this.
It is totally unsafe. Besides, I do not think it is worth to make
the fix and the test as two separate commits---can I ask you to help
coordinate co-authorship between Ramsay and Bagas to come up with a
combined single patch?
Thanks.
prev parent reply other threads:[~2021-04-29 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 7:24 [PATCH v4] t6030: add test for git bisect skip started with --term* arguments Bagas Sanjaya
2021-04-29 8:05 ` Christian Couder
2021-04-29 8:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqim45h585.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=bagasdotme@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=pranit.bauva@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=sunshine@sunshineco.com \
--cc=trygveaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.