From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH 2/2] transport: make transport vtable more private
Date: Thu, 14 Dec 2017 14:13:42 -0800 [thread overview]
Message-ID: <xmqqind9rm95.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <26f276956001a120cc9105b0071762c2fd4a45c5.1513287544.git.jonathantanmy@google.com> (Jonathan Tan's message of "Thu, 14 Dec 2017 13:44:45 -0800")
Jonathan Tan <jonathantanmy@google.com> writes:
> Move the definition of the transport-specific functions provided by
> transports, whether declared in transport.c or transport-helper.c, into
> an internal header. This means that transport-using code (as opposed to
> transport-declaring code) can no longer access these functions (without
> importing the internal header themselves), making it clear that they
> should use the transport_*() functions instead, and also allowing the
> interface between the transport mechanism and an individual transport to
> independently evolve.
Yay!
prev parent reply other threads:[~2017-12-14 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 21:44 [PATCH 0/2] More transport API improvements Jonathan Tan
2017-12-14 21:44 ` [PATCH 1/2] clone, fetch: remove redundant transport check Jonathan Tan
2017-12-14 22:12 ` Junio C Hamano
2017-12-14 21:44 ` [PATCH 2/2] transport: make transport vtable more private Jonathan Tan
2017-12-14 22:13 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqind9rm95.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.