From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Toni Uebernickel <tuebernickel@gmail.com>,
git@vger.kernel.org, Tsvi Mostovicz <ttmost@gmail.com>,
Jeff King <peff@peff.net>
Subject: Re: Updated to v2.14.2 on macOS; git add --patch broken
Date: Tue, 03 Oct 2017 11:25:44 +0900 [thread overview]
Message-ID: <xmqqinfxklw7.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqpoa5kp0c.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Tue, 03 Oct 2017 10:18:27 +0900")
Junio C Hamano <gitster@pobox.com> writes:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> Yet another alternative would be to treat color.ui=always as a
>> deprecated synonym for color.ui=auto. I think that's my preferred
>> fix.
>
> It is mine, too. And I do not think color.ui=absolutely-always for
> those who want to keep the current behaviour is unneeded.
Having said that, I do not mind solving what 136c8c8b ("color: check
color.ui in git_default_config()", 2017-07-13) tried to do in a
different way. If 4c7f1819b that made even plumbing to default to
auto was wrong (because plumbing did not pay attention to color.ui
so people could not override that 'auto' default), we can partially
revert 4c7f1819 ("make color.ui default to 'auto'", 2013-06-10) to
make the default 'auto' not apply to plumbing.
In any case, I think the first step may be to revert 136c8c8b from
both 'master' and 2.14.x. These alternative solutions can come on
top.
Thoughts?
next prev parent reply other threads:[~2017-10-03 2:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 13:23 Updated to v2.14.2 on macOS; git add --patch broken Toni Uebernickel
2017-09-27 17:07 ` Jeff King
2017-09-27 17:28 ` Toni Uebernickel
2017-09-27 18:01 ` Jeff King
2017-09-27 19:51 ` Jonathan Nieder
2017-09-27 19:53 ` Jonathan Nieder
2017-09-28 5:03 ` Toni Uebernickel
2017-09-28 5:20 ` Jeff King
2017-09-28 5:31 ` Toni Uebernickel
2017-10-02 23:00 ` Jonathan Nieder
2017-10-03 1:18 ` Junio C Hamano
2017-10-03 2:25 ` Junio C Hamano [this message]
2017-10-03 3:14 ` Junio C Hamano
2017-10-03 6:15 ` Jeff King
2017-10-03 7:10 ` Junio C Hamano
2017-10-03 7:16 ` Jeff King
2017-10-03 8:34 ` Junio C Hamano
2017-10-03 8:45 ` Jeff King
2017-10-03 8:56 ` Junio C Hamano
2017-10-03 9:10 ` Jeff King
2017-10-03 9:18 ` Tsvi Mostovicz
2017-10-03 10:38 ` Junio C Hamano
2017-10-03 13:37 ` Jeff King
2017-10-03 13:39 ` [PATCH 01/12] test-terminal: set TERM=vt100 Jeff King
2017-10-03 13:40 ` [PATCH 02/12] t4015: prefer --color to -c color.diff=always Jeff King
2017-10-03 13:41 ` [PATCH 03/12] t4015: use --color with --color-moved Jeff King
2017-10-03 13:42 ` [PATCH 04/12] t3701: use test-terminal to collect color output Jeff King
2017-10-03 13:43 ` [PATCH 05/12] t7508: use test_terminal for " Jeff King
2017-10-03 13:43 ` [PATCH 06/12] t7502: use diff.noprefix for --verbose test Jeff King
2017-10-03 13:44 ` [PATCH 07/12] t6006: drop "always" color config tests Jeff King
2017-10-03 13:44 ` [PATCH 08/12] t3203: drop "always" color test Jeff King
2017-10-03 13:44 ` [PATCH 09/12] t7301: use test_terminal to check color Jeff King
2017-10-03 13:45 ` [PATCH 10/12] t3205: use --color instead of color.branch=always Jeff King
2017-10-03 13:45 ` [PATCH 11/12] provide --color option for all ref-filter users Jeff King
2017-10-03 13:46 ` [PATCH 12/12] color: make "always" the same as "auto" in config Jeff King
2017-10-04 2:59 ` Updated to v2.14.2 on macOS; git add --patch broken Junio C Hamano
2017-10-05 10:06 ` Jeff King
2017-10-20 13:31 ` Jan Prachař
2017-10-03 9:31 ` Jeff King
2017-10-03 4:07 ` [PATCH 0/2] fixing "add -p" regression Junio C Hamano
2017-10-03 4:07 ` [PATCH 1/2] Revert "color: check color.ui in git_default_config()" Junio C Hamano
2017-10-03 4:07 ` [PATCH 2/2] colors: git_default_config() does not read color.ui Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqinfxklw7.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=ttmost@gmail.com \
--cc=tuebernickel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.