From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org, tboegi@web.de
Subject: Re: [PATCH v5 2/9] connect: only match the host with core.gitProxy
Date: Mon, 16 May 2016 15:54:25 -0700 [thread overview]
Message-ID: <xmqqinydzk9q.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160516223639.GA16182@glandium.org> (Mike Hommey's message of "Tue, 17 May 2016 07:36:39 +0900")
Mike Hommey <mh@glandium.org> writes:
> The gitProxy script gets the port passed. Why would you need different
> scripts for different ports if the port is passed as an argument? Also,
> if it's deliberate, it's widely undocumented.
Fair enough.
A user who has been working around thsi "oversight", would have
relied on her proxy configured with 'script for myhost.xz:9111' to
be called for git://myhost.xz:9111/path, right? We'd need to
somehow let her know that her configuration will be broken, but as
long as we can find a way to do so to ease the transition, I think
the updated "if you want to use a different behaviour depending on
port, use the port parameter" is a lot more sensible behaviour than
what we had traditionally.
next prev parent reply other threads:[~2016-05-16 22:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 0:07 [PATCH v5 0/9] connect: various cleanups Mike Hommey
2016-05-16 0:07 ` [PATCH v5 1/9] connect: call get_host_and_port() earlier Mike Hommey
2016-05-16 0:07 ` [PATCH v5 2/9] connect: only match the host with core.gitProxy Mike Hommey
2016-05-16 22:30 ` Junio C Hamano
2016-05-16 22:36 ` Mike Hommey
2016-05-16 22:54 ` Junio C Hamano [this message]
2016-05-16 0:07 ` [PATCH v5 3/9] connect: fill the host header in the git protocol with the host and port variables Mike Hommey
2016-05-16 0:07 ` [PATCH v5 4/9] connect: make parse_connect_url() return separated host and port Mike Hommey
2016-05-16 22:39 ` Junio C Hamano
2016-05-16 22:53 ` Mike Hommey
2016-05-16 0:07 ` [PATCH v5 5/9] connect: group CONNECT_DIAG_URL handling code Mike Hommey
2016-05-16 0:07 ` [PATCH v5 6/9] connect: make parse_connect_url() return the user part of the url as a separate value Mike Hommey
2016-05-16 0:07 ` [PATCH v5 7/9] connect: change the --diag-url output to separate user and host Mike Hommey
2016-05-16 0:07 ` [PATCH v5 8/9] connect: actively reject git:// urls with a user part Mike Hommey
2016-05-16 22:41 ` Junio C Hamano
2016-05-16 0:07 ` [PATCH v5 9/9] connect: move ssh command line preparation to a separate function Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqinydzk9q.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.