All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Sébastien Guimmara" <sebastien.guimmara@gmail.com>,
	"Git List" <git@vger.kernel.org>
Subject: Re: [PATCH v10 5/5] help: respect new common command grouping
Date: Thu, 21 May 2015 09:16:07 -0700	[thread overview]
Message-ID: <xmqqiobllxdk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cRX9_1h4W6sWxb22FF3Hwgqx2f=hK=tQkfTUdkTJiQo-w@mail.gmail.com> (Eric Sunshine's message of "Thu, 21 May 2015 10:29:05 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

>> +
>> +       puts(_("These are common Git commands used in various situations:"));
>
> The clause "in various situations" is quite nebulous and thus adds no
> substance.

FWIW I view the latter half of that sentence as explaining the group
labels which we did not have (so we did not have to mention in the
original).  Perhaps swapping the order may clarify, as the list
itself is a two-level, i.e. list of workflow elements, each of which
has list of commands?

  reply	other threads:[~2015-05-21 16:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 13:13 [PATCH v10 0/5] group common commands by theme Sébastien Guimmara
2015-05-21 13:13 ` [PATCH v10 1/5] command-list: prepare machinery for upcoming "common groups" section Sébastien Guimmara
2015-05-21 13:48   ` Eric Sunshine
2015-05-21 13:55     ` Sébastien Guimmara
2015-05-21 14:16       ` Eric Sunshine
2015-05-21 13:13 ` [PATCH v10 2/5] command-list.txt: add the common groups block Sébastien Guimmara
2015-05-21 13:13 ` [PATCH v10 3/5] generate-cmdlist: parse common group commands Sébastien Guimmara
2015-05-21 13:13 ` [PATCH v10 4/5] command-list.txt: drop the "common" tag Sébastien Guimmara
2015-05-21 13:13 ` [PATCH v10 5/5] help: respect new common command grouping Sébastien Guimmara
2015-05-21 14:29   ` Eric Sunshine
2015-05-21 16:16     ` Junio C Hamano [this message]
2015-05-21 16:46       ` Eric Sunshine
2015-05-21 17:15         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqiobllxdk.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sebastien.guimmara@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.