From: Junio C Hamano <gitster@pobox.com>
To: Lewis Diamond <git@lewisdiamond.com>
Cc: git@vger.kernel.org
Subject: Re: The fetch command should "always" honor remote.<name>.fetch
Date: Wed, 09 Apr 2014 11:40:21 -0700 [thread overview]
Message-ID: <xmqqioqi1h4a.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAHwd=GnRHM9Nk7SzCL46cLTrxgGYH+F9O7KBOxnJmAQQRvKhSA@mail.gmail.com> (Lewis Diamond's message of "Wed, 9 Apr 2014 11:57:19 -0400")
Lewis Diamond <git@lewisdiamond.com> writes:
> ... Yes, I agree that the abbreviation expansion works as designed
> (using the rev_parse_rules),
I am not fundamentally opposed if you want to add a new command line
option to "git fetch" so that the shortened "what to fetch" are
dwimmed differently, but changing how "git fetch there master"
without any such option behaves will not fly well. It will break
those who have already learned Git who expect that that is the way
to explicitly ask to fetch the master branch regardless of what
configuration the repository might have.
It is true that "git fetch there 'master'" cannot possibly mean the
'master' branch we locally have, so there is no fundamental reason
why we should use the same rev-parse dwim rules to grok them.
In fact we used to have different dwim rules for local (rev-parse
dwim rules) and for remote access --- I do not offhand recall if we
had rules for push and fetch separately, but I wouldn't be surprised
if we did. The underlying mechanism certainly allowed us to use
separate rules for them back then.
Over time, however, having separate rules for remote and local was
found confusing by users, and that is why we changed the code to use
the same rule everywhere when dwimming the abbreviated refname on
the command line these days.
prev parent reply other threads:[~2014-04-09 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-05 22:43 The fetch command should "always" honor remote.<name>.fetch Lewis Diamond
2014-04-07 18:23 ` Junio C Hamano
2014-04-07 18:46 ` Lewis Diamond
2014-04-09 1:45 ` Junio C Hamano
2014-04-09 15:57 ` Lewis Diamond
2014-04-09 18:40 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqioqi1h4a.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@lewisdiamond.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.