All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Christian Couder <christian.couder@gmail.com>,  git@vger.kernel.org
Subject: Re: [PATCH v3 4/6] odb/source-files: simplify directory duplication detection
Date: Wed, 28 Oct 2026 09:27:47 -0700	[thread overview]
Message-ID: <xmqqjyn1bxj0.fsf@gitster.g> (raw)
In-Reply-To: <auG7Ru6MhhXzrVd-@pks.im> (Patrick Steinhardt's message of "Wed, 28 Oct 2026 10:07:18 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> On Wed, Oct 28, 2026 at 09:59:57AM +0100, Christian Couder wrote:
>> On Wed, Oct 28, 2026 at 8:11 AM Patrick Steinhardt <ps@pks.im> wrote:
>> 
>> > Rename `dirs_paths_icase` to `dir_paths_iscase` to match the naming of
>> 
>> Nit: s/dir_paths_iscase/dir_paths_icase/
>> 
>> Otherwise the whole v3 looks good to me. Thanks.
>
> D'oh. To many s's that tripped me here. I've queued this locally, but
> will refrain from sending a new version just to fix this one commit
> message typo.
>
> Thanks for your review!
>
> Patrick

If you have a single list of less than 7 lines to fix up, I can do so
locally before applying.

Thanks, all.

  reply	other threads:[~2026-10-28 16:27 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20  8:54 [PATCH 0/4] odb/files: reload alternates on retry again Patrick Steinhardt
2026-10-20  8:54 ` [PATCH 1/4] odb/source-files: rename alternates-related functions Patrick Steinhardt
2026-10-20  8:54 ` [PATCH 2/4] odb/source-files: reload alternates on retry Patrick Steinhardt
2026-10-21 14:32   ` Christian Couder
2026-10-23 11:57     ` Patrick Steinhardt
2026-10-20  8:54 ` [PATCH 3/4] odb/source-files: avoid rechecking already-known alternates Patrick Steinhardt
2026-10-20  8:54 ` [PATCH 4/4] odb/source-files: only reload alternates when the file has changed Patrick Steinhardt
2026-10-20 19:59   ` Junio C Hamano
2026-10-21 10:17     ` Patrick Steinhardt
2026-10-23 12:47 ` [PATCH v2 0/6] odb/files: reload alternates on retry again Patrick Steinhardt
2026-10-23 12:48   ` [PATCH v2 1/6] odb/source-files: rename alternates-related functions Patrick Steinhardt
2026-10-23 12:48   ` [PATCH v2 2/6] odb/source-files: always load alternates via primary object directory Patrick Steinhardt
2026-10-27 12:20     ` Christian Couder
2026-10-23 12:48   ` [PATCH v2 3/6] odb/source-files: reload alternates on retry Patrick Steinhardt
2026-10-23 12:48   ` [PATCH v2 4/6] odb/source-files: simplify directory duplication detection Patrick Steinhardt
2026-10-27 12:13     ` Christian Couder
2026-10-27 13:14       ` Patrick Steinhardt
2026-10-23 12:48   ` [PATCH v2 5/6] odb/source-files: avoid stat'ing already-known alternates Patrick Steinhardt
2026-10-27 12:36     ` Christian Couder
2026-10-27 13:14       ` Patrick Steinhardt
2026-10-27 14:31         ` Christian Couder
2026-10-28  7:08           ` Patrick Steinhardt
2026-10-23 12:48   ` [PATCH v2 6/6] odb/source-files: only reload alternates when the file has changed Patrick Steinhardt
2026-10-27 11:22     ` Christian Couder
2026-10-27 13:15       ` Patrick Steinhardt
2026-10-27 12:43   ` [PATCH v2 0/6] odb/files: reload alternates on retry again Christian Couder
2026-10-28  7:11 ` [PATCH v3 " Patrick Steinhardt
2026-10-28  7:11   ` [PATCH v3 1/6] odb/source-files: rename alternates-related functions Patrick Steinhardt
2026-10-28  7:11   ` [PATCH v3 2/6] odb/source-files: always load alternates via primary object directory Patrick Steinhardt
2026-10-28  7:11   ` [PATCH v3 3/6] odb/source-files: reload alternates on retry Patrick Steinhardt
2026-10-28  7:11   ` [PATCH v3 4/6] odb/source-files: simplify directory duplication detection Patrick Steinhardt
2026-10-28  8:59     ` Christian Couder
2026-10-28  9:07       ` Patrick Steinhardt
2026-10-28 16:27         ` Junio C Hamano [this message]
2026-10-28  7:11   ` [PATCH v3 5/6] odb/source-files: avoid stat'ing already-known alternates Patrick Steinhardt
2026-10-28  7:11   ` [PATCH v3 6/6] odb/source-files: only reload alternates when the file has changed Patrick Steinhardt
2026-10-28 16:12   ` [PATCH v3 0/6] odb/files: reload alternates on retry again Junio C Hamano
2026-10-29  8:37     ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqjyn1bxj0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.