From: Junio C Hamano <gitster@pobox.com>
To: "Michael Montalbo via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>,
"Michael Montalbo" <mmontalbo@gmail.com>
Subject: Re: [PATCH] revision: make get_commit_action() a pure predicate
Date: Fri, 24 Jul 2026 14:37:58 -0700 [thread overview]
Message-ID: <xmqqjyqk3w7d.fsf@gitster.g> (raw)
In-Reply-To: <pull.2169.git.1784143793613.gitgitgadget@gmail.com> (Michael Montalbo via GitGitGadget's message of "Wed, 15 Jul 2026 19:29:52 +0000")
"Michael Montalbo via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Add a "line-log-peek" subcommand to the revision-walking test helper
> that evaluates get_commit_action() on a commit the walk has not reached
> yet, plus a t4211 check that the call leaves the commit's flags
> unchanged. The flags are compared rather than the commit list because
> add_line_range() merges ranges by union, which is idempotent, so the
> side effect never changed which commits a linear -L history shows.
>
> Suggested-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Michael Montalbo <mmontalbo@gmail.com>
> ---
> revision: make get_commit_action() a pure predicate
Sorry, but I completely lost track and I do not recall suggesting a
change that amounts to 100+ lines of new lines. Are we doing any
code clean-up? Bugfix? A new feature?
prev parent reply other threads:[~2026-07-24 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 19:29 [PATCH] revision: make get_commit_action() a pure predicate Michael Montalbo via GitGitGadget
2026-07-24 21:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjyqk3w7d.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=mmontalbo@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.