From: Junio C Hamano <gitster@pobox.com>
To: "Paul Tarjan via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood123@gmail.com>,
Paul Tarjan <paul@paultarjan.com>,
Paul Tarjan <github@paulisageek.com>
Subject: Re: [PATCH v3] t7800: fix racy "difftool --dir-diff syncs worktree" test
Date: Sun, 04 Jan 2026 11:34:53 +0900 [thread overview]
Message-ID: <xmqqjyxyp0ky.fsf@gitster.g> (raw)
In-Reply-To: <pull.2149.v3.git.git.1767472809897.gitgitgadget@gmail.com> (Paul Tarjan via GitGitGadget's message of "Sat, 03 Jan 2026 20:40:09 +0000")
"Paul Tarjan via GitGitGadget" <gitgitgadget@gmail.com> writes:
> On Windows, this is more likely to manifest because Git relies on
> inode changes as a fallback when other stat fields match, but Windows
> filesystems lack inodes.
"inode" -> "inode number" (or "ino" / "inum")?
I suspect the same issue would bite users on network file systems,
so while avoiding problematic scenarios in tests may improve the
pass rate of the tests, we may want to fix the underlying issue with
the difftool command for real in the longer term.
Regardless, will queue this updated patch. Thanks.
next prev parent reply other threads:[~2026-01-04 2:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 22:19 [PATCH] t7800: fix racy "difftool --dir-diff syncs worktree" test Paul Tarjan via GitGitGadget
2026-01-01 14:49 ` Johannes Schindelin
2026-01-01 18:27 ` [PATCH v2] " Paul Tarjan via GitGitGadget
2026-01-01 22:49 ` Junio C Hamano
2026-01-03 9:39 ` Phillip Wood
2026-01-03 16:30 ` Paul Tarjan
2026-01-03 20:29 ` Johannes Schindelin
2026-01-04 2:27 ` Junio C Hamano
2026-01-03 20:40 ` [PATCH v3] " Paul Tarjan via GitGitGadget
2026-01-04 2:34 ` Junio C Hamano [this message]
2026-01-05 10:33 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjyxyp0ky.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=github@paulisageek.com \
--cc=paul@paultarjan.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.