From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Han Young <hanyang.tony@bytedance.com>,
git@vger.kernel.org, Han Young <hanyoung@protonmail.com>
Subject: Re: [PATCH 0/1] files-backend: check symref name before update
Date: Thu, 02 Oct 2025 07:45:18 -0700 [thread overview]
Message-ID: <xmqqjz1dxszl.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZSboPeTNSSh1fsaKc+Ef5DhaKGX+mNiRzyYfvFERa=JLQ@mail.gmail.com> (Karthik Nayak's message of "Thu, 2 Oct 2025 02:34:53 -0700")
Karthik Nayak <karthik.188@gmail.com> writes:
> The bigger question for me is if there is an instance that you'd want to
> modify the HEAD file manually. Or is there a way this can be done via
> any of the existing Git commands. Otherwise, I'm not sure I would call
> this a bug.
As we discussed downthread, I tend to agree with you here that this
is a corrupt repository leading the tool to do a nonsensical thing,
and the true bug here is that "fsck" is not catching it. But I do
not mind if we add a check at runtime, probably at the location the
patch under discussion identified, that makes sure a symbolic ref
points at a valid target the same way "git fsck" does.
Thanks.
prev parent reply other threads:[~2025-10-02 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 15:08 [PATCH 0/1] files-backend: check symref name before update Han Young
2025-10-01 15:08 ` [PATCH 1/1] " Han Young
2025-10-01 19:22 ` Junio C Hamano
2025-10-02 9:54 ` Karthik Nayak
2025-10-02 11:47 ` Patrick Steinhardt
2025-10-02 13:36 ` Junio C Hamano
2025-10-02 15:30 ` Patrick Steinhardt
2025-10-02 17:34 ` Junio C Hamano
2025-10-05 8:19 ` shejialuo
2025-10-02 9:34 ` [PATCH 0/1] " Karthik Nayak
2025-10-02 14:45 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjz1dxszl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanyang.tony@bytedance.com \
--cc=hanyoung@protonmail.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.