From: Junio C Hamano <gitster@pobox.com>
To: Lidong Yan <502024330056@smail.nju.edu.cn>
Cc: git@vger.kernel.org, ayu.chandekar@gmail.com,
christian.couder@gmail.com, shyamthakkar001@gmail.com
Subject: Re: [PATCH v2] git.c: remove the_repository dependence in run_builtin()
Date: Sun, 15 Jun 2025 22:41:36 -0700 [thread overview]
Message-ID: <xmqqjz5c2qgf.fsf@gitster.g> (raw)
In-Reply-To: <191FDEFA-786C-4CD7-9D4F-06495FCBDDA6@smail.nju.edu.cn> (Lidong Yan's message of "Mon, 16 Jun 2025 13:36:41 +0800")
Lidong Yan <502024330056@smail.nju.edu.cn> writes:
> Which looks even worse, I will leave this comment intact.
That is perfectly fine. After all, this is not about comment style.
It is about the_repository. Let's stay focused on that.
next prev parent reply other threads:[~2025-06-16 5:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 4:59 [PATCH] git.c: remove the_repository dependence in run_builtin() Lidong Yan
2025-06-12 17:16 ` Junio C Hamano
2025-06-13 1:53 ` lidongyan
2025-06-13 4:49 ` Junio C Hamano
2025-06-14 5:03 ` [PATCH v2] " Lidong Yan
2025-06-14 23:35 ` Junio C Hamano
2025-06-15 1:49 ` Lidong Yan
2025-06-16 0:53 ` Junio C Hamano
2025-06-16 5:36 ` Lidong Yan
2025-06-16 5:41 ` Junio C Hamano [this message]
2025-06-15 14:46 ` [RFC PATCH v3 0/2] small fixes for git.c and setup.c Lidong Yan
2025-06-15 14:46 ` [PATCH v3 1/2] git.c: remove the_repository dependence in run_builtin() Lidong Yan
2025-06-15 14:46 ` [PATCH v3 2/2] setup: fix NEEDSWORK in setup_git_directory_gently() Lidong Yan
2025-06-16 1:25 ` [RFC PATCH v3 0/2] small fixes for git.c and setup.c Junio C Hamano
2025-06-16 1:36 ` Lidong Yan
2025-06-16 6:22 ` [PATCH v4] git.c: remove the_repository dependence in run_builtin() Lidong Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjz5c2qgf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=502024330056@smail.nju.edu.cn \
--cc=ayu.chandekar@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=shyamthakkar001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.