All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Rubén Justo" <rjusto@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] tests: drop use of 'tee' that hides exit status
Date: Thu, 08 Aug 2024 18:25:07 -0700	[thread overview]
Message-ID: <xmqqjzgqfpxo.fsf@gitster.g> (raw)
In-Reply-To: <93e6fdd3-4a15-4cc5-929a-aa5e79f44e1c@gmail.com> ("Rubén Justo"'s message of "Fri, 9 Aug 2024 02:37:29 +0200")

Rubén Justo <rjusto@gmail.com> writes:

>> In none of these tests, I do not see a reason why we want to hide a
>
> This double negative caught my attention.  The message is
> understandable; perhaps "In none of these tests I see ..." would have
> been clearer.

You're absolutely right, and it is not just "would have been
clearer"---your fix makes a nonsense double-negation into a correct
sentence.  I'd go with "In any of ... I do not see" while queuing.

Thanks.

  reply	other threads:[~2024-08-09  1:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-08 21:19 [PATCH] tests: drop use of 'tee' that hides exit status Junio C Hamano
2024-08-09  0:37 ` Rubén Justo
2024-08-09  1:25   ` Junio C Hamano [this message]
2024-08-13 12:22 ` Johannes Schindelin
2024-08-13 12:59   ` Jeff King
2024-08-13 17:23   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqjzgqfpxo.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=rjusto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.