All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Orgad Shaneh <orgads@gmail.com>,
	 Eric Sunshine <sunshine@sunshineco.com>,
	 Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH v2] prune: mark rebase autostash and orig-head as reachable
Date: Fri, 09 Feb 2024 10:04:46 -0800	[thread overview]
Message-ID: <xmqqjzndfr9d.fsf@gitster.g> (raw)
In-Reply-To: <pull.1656.v2.git.1707495579886.gitgitgadget@gmail.com> (Phillip Wood via GitGitGadget's message of "Fri, 09 Feb 2024 16:19:39 +0000")

"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:

> +static void add_rebase_files(struct rev_info *revs)
> +{
> +	struct strbuf buf = STRBUF_INIT;
> +	size_t len;
> +	const char *path[] = {
> +		"rebase-apply/autostash",
> +		"rebase-apply/orig-head",
> +		"rebase-merge/autostash",
> +		"rebase-merge/orig-head",
> +	};

Yuck.

Having this table here makes the sequencer subsystem even less
maintainable than it already is.  I wonder if we can at least
somehow share some of these?  #leftoverbits.

Thanks.


      reply	other threads:[~2024-02-09 18:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08 17:00 [PATCH] prune: mark rebase autostash and orig-head as reachable Phillip Wood via GitGitGadget
2024-02-08 17:25 ` Eric Sunshine
2024-02-09 11:08   ` Phillip Wood
2024-02-08 18:06 ` Junio C Hamano
2024-02-09 14:15   ` Phillip Wood
2024-05-14 19:37   ` Phil Hord
2024-02-09 16:19 ` [PATCH v2] " Phillip Wood via GitGitGadget
2024-02-09 18:04   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqjzndfr9d.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=orgads@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.