All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Md Isfarul Haque via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Md Isfarul Haque <isfarul.876@gmail.com>
Subject: Re: [PATCH 0/2] [GSoC][RFC/Patch] FIX: use utf8_strnwidth for line_prefix in diff.c
Date: Wed, 24 Jan 2024 09:42:50 -0800	[thread overview]
Message-ID: <xmqqjznyfx0l.fsf@gitster.g> (raw)
In-Reply-To: <pull.1653.git.git.1706105064.gitgitgadget@gmail.com> (Md Isfarul Haque via GitGitGadget's message of "Wed, 24 Jan 2024 14:04:22 +0000")

"Md Isfarul Haque via GitGitGadget" <gitgitgadget@gmail.com> writes:

> This patch adresses diff.c:2721 and proposes the fix using a new function.

Yay.  My favorite long-time pet-peeve topic.

>
> Md Isfarul Haque (2):
>   FIX: use utf8_strnwidth for line_prefix in diff.c
>   FIX memory leak in one branch

Our convention does not use "FIX" and other prefix on the subject.
Please check Documentation/SubmittingPatches.

Thanks.

      parent reply	other threads:[~2024-01-24 17:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 14:04 [PATCH 0/2] [GSoC][RFC/Patch] FIX: use utf8_strnwidth for line_prefix in diff.c Md Isfarul Haque via GitGitGadget
2024-01-24 14:04 ` [PATCH 1/2] " Md Isfarul Haque via GitGitGadget
2024-01-24 20:01   ` Christian Couder
2024-01-25  5:42     ` Md Isfarul Haque
2024-01-24 20:08   ` Junio C Hamano
2024-01-25  5:52     ` Md Isfarul Haque
2024-01-24 14:04 ` [PATCH 2/2] FIX memory leak in one branch Md Isfarul Haque via GitGitGadget
2024-01-24 20:11   ` Junio C Hamano
2024-01-24 17:42 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqjznyfx0l.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=isfarul.876@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.