From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, Elijah Newren <newren@gmail.com>,
Calvin Wan <calvinwan@google.com>
Subject: Re: [PATCH 1/3] var: add support for listing the shell
Date: Thu, 22 Jun 2023 14:05:39 -0700 [thread overview]
Message-ID: <xmqqjzvvdx7g.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cSTR6oHeYjcHZ7m2CKYcFo2eistxz_X-7J2rhd7h+uf3g@mail.gmail.com> (Eric Sunshine's message of "Thu, 22 Jun 2023 16:42:31 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> This can be implemented more simply without a temporary file:
>
> shpath=$(git var GIT_SHELL_PATH) &&
> test -x "$shpath"
>
> This is safe since the exit code of the Git command is preserved
> across the `shpath=...` assignment.
Correct. I also suspect that we want to add test_path_is_executable
helper next to test_path_is_{file,dir,missing} helpers and list it
in t/README. One downside of your approach is that the output from
the command is only in $shpath and cannot be observed easily in the
$TRASH_DIRECTORY after the test fails, but with such a helper we can
report the problematic path when the expectation fails.
Thanks.
next prev parent reply other threads:[~2023-06-22 21:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 19:50 [PATCH 0/3] Additional variables for git var brian m. carlson
2023-06-22 19:50 ` [PATCH 1/3] var: add support for listing the shell brian m. carlson
2023-06-22 20:42 ` Eric Sunshine
2023-06-22 21:05 ` Junio C Hamano [this message]
2023-06-22 21:13 ` Eric Sunshine
2023-06-22 21:25 ` brian m. carlson
2023-06-22 21:41 ` Junio C Hamano
2023-06-22 21:20 ` brian m. carlson
2023-06-22 19:50 ` [PATCH 2/3] var: add attributes files locations brian m. carlson
2023-06-22 20:19 ` Derrick Stolee
2023-06-22 21:17 ` brian m. carlson
2023-06-22 21:37 ` Junio C Hamano
2023-06-22 21:17 ` Junio C Hamano
2023-06-22 21:18 ` Eric Sunshine
2023-06-22 21:30 ` brian m. carlson
2023-06-22 21:21 ` Eric Sunshine
2023-06-22 19:50 ` [PATCH 3/3] var: add config file locations brian m. carlson
2023-06-22 21:35 ` Eric Sunshine
2023-06-26 19:00 ` [PATCH v2 0/7] Additional variables for git var brian m. carlson
2023-06-26 19:00 ` [PATCH v2 1/7] t: add a function to check executable bit brian m. carlson
2023-06-26 19:00 ` [PATCH v2 2/7] var: add support for listing the shell brian m. carlson
2023-06-26 19:00 ` [PATCH v2 3/7] var: format variable structure with C99 initializers brian m. carlson
2023-06-26 19:00 ` [PATCH v2 4/7] var: adjust memory allocation for strings brian m. carlson
2023-06-26 19:56 ` Junio C Hamano
2023-06-26 19:00 ` [PATCH v2 5/7] attr: expose and rename accessor functions brian m. carlson
2023-06-26 19:58 ` Junio C Hamano
2023-06-26 19:00 ` [PATCH v2 6/7] var: add attributes files locations brian m. carlson
2023-06-27 7:05 ` Jeff King
2023-06-27 16:12 ` brian m. carlson
2023-06-27 17:56 ` Junio C Hamano
2023-06-27 20:16 ` Jeff King
2023-06-26 19:00 ` [PATCH v2 7/7] var: add config file locations brian m. carlson
2023-06-26 20:02 ` Junio C Hamano
2023-06-27 16:18 ` [PATCH v3 0/8] Additional variables for git var brian m. carlson
2023-06-27 16:18 ` [PATCH v3 1/8] var: mark unused parameters in git_var callbacks brian m. carlson
2023-06-27 16:18 ` [PATCH v3 2/8] t: add a function to check executable bit brian m. carlson
2023-06-27 16:18 ` [PATCH v3 3/8] var: add support for listing the shell brian m. carlson
2023-06-27 16:18 ` [PATCH v3 4/8] var: format variable structure with C99 initializers brian m. carlson
2023-06-27 16:18 ` [PATCH v3 5/8] var: adjust memory allocation for strings brian m. carlson
2023-06-27 16:19 ` [PATCH v3 6/8] attr: expose and rename accessor functions brian m. carlson
2023-06-27 16:19 ` [PATCH v3 7/8] var: add attributes files locations brian m. carlson
2023-06-27 16:19 ` [PATCH v3 8/8] var: add config file locations brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjzvvdx7g.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=calvinwan@google.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.