All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kousik Sanagavarapu <five231003@gmail.com>
Cc: git@vger.kernel.org, newren@gmail.com
Subject: Re: [GSoC][PATCH] commit: warn the usage of reverse_commit_list() helper
Date: Tue, 07 Feb 2023 10:53:10 -0800	[thread overview]
Message-ID: <xmqqk00tz4rt.fsf@gitster.g> (raw)
In-Reply-To: 20230207150359.177641-1-five231003@gmail.com

Kousik Sanagavarapu <five231003@gmail.com> writes:

> -/* Modify list in-place to reverse it, returning new head; list will be tail */
> +/*
> + * Modify list in-place to reverse it, returning new head; list will be tail.
> + *
> + * NOTE! The reversed list is constructed using the elements of the original
> + * list, hence losing the original list.
> + */

After re-reading the original, I realize that "in-place" is good
enough clue to say that this is destructive.




  parent reply	other threads:[~2023-02-07 18:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 15:03 [GSoC][PATCH] commit: warn the usage of reverse_commit_list() helper Kousik Sanagavarapu
2023-02-07 17:56 ` Ævar Arnfjörð Bjarmason
2023-02-08 15:53   ` Kousik Sanagavarapu
2023-02-07 18:53 ` Junio C Hamano [this message]
2023-02-08 16:00   ` Kousik Sanagavarapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk00tz4rt.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=five231003@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.