From: Junio C Hamano <gitster@pobox.com>
To: Siddharth Asthana <siddharthasthana31@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com, johncai86@gmail.com
Subject: Re: [PATCH] doc/cat-file: allow --use-mailmap for --batch options
Date: Fri, 21 Oct 2022 11:56:23 -0700 [thread overview]
Message-ID: <xmqqk04tj99k.fsf@gitster.g> (raw)
In-Reply-To: <20221021103442.202759-1-siddharthasthana31@gmail.com> (Siddharth Asthana's message of "Fri, 21 Oct 2022 16:04:41 +0530")
Siddharth Asthana <siddharthasthana31@gmail.com> writes:
> Changes in v3:
> - Fixed formatting
This seems to format well, both with AsciiDoc and Asciidoctor.
> - on stdin. May not be combined with any other options or arguments
> - except `--textconv` or `--filters`, in which case the input lines
> - also need to specify the path, separated by whitespace. See the
> - section `BATCH OUTPUT` below for details.
> + on stdin. May not be combined with any other options or arguments
Unnecessary change here, but I'll let it pass this time.
> + except --textconv, --filters, or --use-mailmap.
> + +
> + * When used with `--textconv` or `--filters`, the input lines
> + must specify the path, separated by whitespace. See the section
> + `BATCH OUTPUT` below for details.
OK.
> + +
> + * When used with `--use-mailmap`, the info command shows the size
> + the object if the identities recorded in it were replaced
> + by the mailmap mechanism.
Did you mean "the object as if the identities ... were replaced"?
All three comments equally apply to the other two hunks for
--batch-check and --batch-command.
Thanks.
next prev parent reply other threads:[~2022-10-21 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 19:35 [PATCH] doc/cat-file: allow --use-mailmap for --batch options Siddharth Asthana
2022-09-24 14:49 ` Christian Couder
2022-09-26 9:14 ` Siddharth Asthana
2022-09-26 14:11 ` John Cai
2022-10-21 10:32 ` Siddharth Asthana
2022-10-21 10:34 ` Siddharth Asthana
2022-10-21 18:56 ` Junio C Hamano [this message]
2022-10-29 9:25 ` Siddharth Asthana
2022-10-29 18:06 ` Taylor Blau
2022-10-30 7:06 ` Christian Couder
2022-10-30 18:07 ` Taylor Blau
2022-10-31 10:54 ` Christian Couder
2022-11-13 21:26 ` Siddharth Asthana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk04tj99k.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=johncai86@gmail.com \
--cc=siddharthasthana31@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.