From: Junio C Hamano <gitster@pobox.com>
To: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Eric Sunshine" <sunshine@sunshineco.com>,
"Jean-Noël Avila" <jn.avila@free.fr>,
"Phillip Wood" <phillip.wood123@gmail.com>,
"Phillip Wood" <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH v2] worktree: add -z option for list subcommand
Date: Thu, 31 Mar 2022 13:37:56 -0700 [thread overview]
Message-ID: <xmqqk0c926zf.fsf@gitster.g> (raw)
In-Reply-To: <pull.1164.v2.git.1648743688825.gitgitgadget@gmail.com> (Phillip Wood via GitGitGadget's message of "Thu, 31 Mar 2022 16:21:28 +0000")
"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> Add a -z option to be used in conjunction with --porcelain that gives
> NUL-terminated output. As 'worktree list --porcelain' does not quote
> worktree paths this enables it to handle worktree paths that contain
> newlines.
>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> ---
> worktree: add -z option for list subcommand
>
> Thanks to Eric, Jean-Noël and Junio for their comments on V1. I've
> reworded the docs and option help and tweaked the tests as suggested by
> Eric, fixed the error messages as suggested by Eric/Jean-Noël and
> changed the implementation to use write_name_quoted() as suggested by
> Junio. I've punted doing anything about quoting the output without -z
> for now, I'll fix that with and without --porcelain in another series.
Thanks for an update. Will queue. I think this iteration is good
to merge to 'next', but let's wait for a few days to see what others
think.
It also made me wonder if "-z" alone should be made to imply
"--porcelain" (in other words, is there a good reason to ask for
NUL-terminated output when you are producing a human-readable
output?), but we can start stricter like this patch does; we can
later loosen it if needed.
next prev parent reply other threads:[~2022-03-31 20:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 15:08 [PATCH] worktree: add -z option for list subcommand Phillip Wood via GitGitGadget
2022-02-25 17:59 ` Junio C Hamano
2022-02-28 8:35 ` Eric Sunshine
2022-02-28 16:10 ` Phillip Wood
2022-02-28 17:16 ` Junio C Hamano
2022-02-28 16:00 ` Phillip Wood
2022-02-28 8:16 ` Eric Sunshine
2022-02-28 11:08 ` Phillip Wood
2022-02-28 9:47 ` Jean-Noël Avila
2022-02-28 10:57 ` Phillip Wood
2022-03-31 16:21 ` [PATCH v2] " Phillip Wood via GitGitGadget
2022-03-31 20:37 ` Junio C Hamano [this message]
2022-04-04 15:47 ` Phillip Wood
2023-05-11 4:11 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0c926zf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jn.avila@free.fr \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.