All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Shubham Verma <shubhunic@gmail.com>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v3 00/10] Modernizing the t7001 test script
Date: Thu, 11 Feb 2021 13:44:29 -0800	[thread overview]
Message-ID: <xmqqk0rewa82.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20210211194704.28913-1-shubhunic@gmail.com> (Shubham Verma's message of "Fri, 12 Feb 2021 01:16:54 +0530")

Shubham Verma <shubhunic@gmail.com> writes:

> In this patch series modernize the t7001 test script by changing the
> style of its tests from an old one to the modern one and by cleaning
> up the test script.
>
> Changes since v2:
>
> - Correct the author name spelling
>
> Thanks everyone for your feedback and suggestions.

I've compared between v2 and v3 and verified the only change is the
name spelling, so I'll port over Eric's reviewed-by's from the
previous round.

Thanks.




  parent reply	other threads:[~2021-02-11 21:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 19:46 [PATCH v3 00/10] Modernizing the t7001 test script Shubham Verma
2021-02-11 19:46 ` [PATCH v3 01/10] t7001: modernize test formatting Shubham Verma
2021-02-11 19:46 ` [PATCH v3 02/10] t7001: indent with TABs instead of spaces Shubham Verma
2021-02-11 19:46 ` [PATCH v3 03/10] t7001: remove unnecessary blank lines Shubham Verma
2021-02-11 19:46 ` [PATCH v3 04/10] t7001: modernize subshell formatting Shubham Verma
2021-02-11 19:46 ` [PATCH v3 05/10] t7001: remove whitespace after redirect operators Shubham Verma
2021-02-11 19:47 ` [PATCH v3 06/10] t7001: avoid using `cd` outside of subshells Shubham Verma
2021-02-11 19:47 ` [PATCH v3 07/10] t7001: use '>' rather than 'touch' Shubham Verma
2021-02-11 19:47 ` [PATCH v3 08/10] t7001: put each command on a separate line Shubham Verma
2021-02-11 19:47 ` [PATCH v3 09/10] t7001: use here-docs instead of echo Shubham Verma
2021-02-11 19:47 ` [PATCH v3 10/10] t7001: use `test` rather than `[` Shubham Verma
2021-02-11 21:44 ` Junio C Hamano [this message]
2021-02-23  8:26   ` [PATCH v3 00/10] Modernizing the t7001 test script Shubham Verma
2021-02-23 17:33     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk0rewa82.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=shubhunic@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.