All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>,
	git@vger.kernel.org, dstolee@microsoft.com, jayconrod@google.com,
	jonathantanmy@google.com
Subject: Re: [PATCH] commit.c: don't persist substituted parents when unshallowing
Date: Wed, 08 Jul 2020 13:55:28 -0700	[thread overview]
Message-ID: <xmqqk0zd20cf.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200708054112.GA118756@google.com> (Jonathan Nieder's message of "Tue, 7 Jul 2020 22:41:12 -0700")

Jonathan Nieder <jrnieder@gmail.com> writes:

> A fairly straightforward test that demonstrates the bug being fixed and
> only relies on what was set up in the initial 'setup' test (4 commits).
> Thanks for tying that loose end.
>
> With or without commit message tweaks along the lines described above,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Thanks for your thoughtful work, as always.

Thanks for a nicely written review.  It would be very nice if we can
see a reroll before I have to tag -rc0.

Thanks.


  reply	other threads:[~2020-07-08 20:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 14:42 [PATCH] commit.c: don't persist substituted parents when unshallowing Taylor Blau
2020-07-07 14:43 ` Taylor Blau
2020-07-08 21:10   ` [PATCH v2] " Taylor Blau
2020-07-09  1:00     ` Jonathan Nieder
2020-07-09  1:21       ` Junio C Hamano
2020-07-08  5:41 ` [PATCH] " Jonathan Nieder
2020-07-08 20:55   ` Junio C Hamano [this message]
2020-07-08 21:22     ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk0zd20cf.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=jayconrod@google.com \
    --cc=jonathantanmy@google.com \
    --cc=jrnieder@gmail.com \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.