All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Han-Wen Nienhuys <hanwenn@gmail.com>,
	Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH] Make some commit hashes in tests reproducible
Date: Tue, 07 Jul 2020 15:37:42 -0700	[thread overview]
Message-ID: <xmqqk0zf2bpl.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200707215206.GA2300296@coredump.intra.peff.net> (Jeff King's message of "Tue, 7 Jul 2020 17:52:06 -0400")

Jeff King <peff@peff.net> writes:

> I'm also skeptical how often we use system times anyway, because _any_
> use of test_commit or test_tick in a script is enough to make all of the
> subsequent commands deterministic. I'd be more inclined to let a
> particular script say "I'm interested in random times". But then, I'd
> think such a script would be better written to trigger its interesting
> cases with a well-crafted set of deterministic times.

Yeah, the DEVELOPER=YesPlease was a tongue-in-cheek comment.  

Reproducibility would mean we see less test breakages due to
raciness, but I do not recall a case where digging into test
breakage due to raciness led to discovery of and fix to a real
breakage in Git itself, so it is probably a good thing.

Thanks.

  reply	other threads:[~2020-07-07 22:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 19:23 [PATCH] Make some commit hashes in tests reproducible Han-Wen Nienhuys via GitGitGadget
2020-07-07 19:50 ` Junio C Hamano
2020-07-07 20:54   ` Jeff King
2020-07-07 21:35     ` Junio C Hamano
2020-07-07 21:52       ` Jeff King
2020-07-07 22:37         ` Junio C Hamano [this message]
2020-07-07 21:41     ` Jeff King
2020-07-08  5:06   ` Han-Wen Nienhuys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk0zf2bpl.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=hanwen@google.com \
    --cc=hanwenn@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.