All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: robbat2@gentoo.org, git@vger.kernel.org
Subject: Re: [PATCH] builtin/pull: respect verbosity settings in submodules
Date: Thu, 25 Jan 2018 11:18:46 -0800	[thread overview]
Message-ID: <xmqqk1w5agrt.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20180125190817.145041-1-sbeller@google.com> (Stefan Beller's message of "Thu, 25 Jan 2018 11:08:17 -0800")

Stefan Beller <sbeller@google.com> writes:

> In a6d7eb2c7a (pull: optionally rebase submodules (remote submodule
> changes only), 2017-06-23), we taught Git how to rebase submodules in
> a pull. However we missed to pass on the verbosity settings.

Makes sense.  Thanks.

>
> Reported-by: Robin H. Johnson <robbat2@gentoo.org>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  builtin/pull.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/builtin/pull.c b/builtin/pull.c
> index 511dbbe0f6..1876271af9 100644
> --- a/builtin/pull.c
> +++ b/builtin/pull.c
> @@ -574,6 +574,7 @@ static int rebase_submodules(void)
>  	cp.no_stdin = 1;
>  	argv_array_pushl(&cp.args, "submodule", "update",
>  				   "--recursive", "--rebase", NULL);
> +	argv_push_verbosity(&cp.args);
>  
>  	return run_command(&cp);
>  }
> @@ -586,6 +587,7 @@ static int update_submodules(void)
>  	cp.no_stdin = 1;
>  	argv_array_pushl(&cp.args, "submodule", "update",
>  				   "--recursive", "--checkout", NULL);
> +	argv_push_verbosity(&cp.args);
>  
>  	return run_command(&cp);
>  }

  reply	other threads:[~2018-01-25 19:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-20  5:57 regression in output of git-pull --rebase --recurse-submodules=yes --quiet Robin H. Johnson
2018-01-25 19:08 ` [PATCH] builtin/pull: respect verbosity settings in submodules Stefan Beller
2018-01-25 19:18   ` Junio C Hamano [this message]
2019-04-10  6:41 ` regression AGAIN in output of git-pull --rebase --recurse-submodules=yes --quiet Robin H. Johnson
2019-04-10 11:18   ` Duy Nguyen
2019-04-12  7:08     ` Robin H. Johnson
2019-04-12  9:25       ` Duy Nguyen
2019-04-15 14:40       ` Johannes Schindelin
     [not found]     ` <CAODn77oL6sj5zvxgPGw=4TNqmnSeBq4=j2r2nx_51YHooECo7w@mail.gmail.com>
2019-04-16  7:48       ` Duy Nguyen
2019-04-12 10:08   ` [PATCH] submodule foreach: fix "<command> --quiet" not being respected Nguyễn Thái Ngọc Duy
2019-04-12 17:22     ` Robin H. Johnson
2019-04-15  2:59       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk1w5agrt.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=robbat2@gentoo.org \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.