From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Joris Valette <joris.valette@gmail.com>,
Andreas Schwab <schwab@linux-m68k.org>,
Jason Pyeron <jpyeron@pdinc.us>,
git@vger.kernel.org
Subject: Re: Consider escaping special characters like 'less' does
Date: Tue, 17 Oct 2017 10:13:34 +0900 [thread overview]
Message-ID: <xmqqk1zur2yp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171016221324.stn56gqnliunvcdv@sigill.intra.peff.net> (Jeff King's message of "Mon, 16 Oct 2017 18:13:24 -0400")
Jeff King <peff@peff.net> writes:
> Alternatively, I suppose we could just always escape in
> add--interactive. I'm trying to think of a case where somebody would
> really want their diffFilter to see the raw bytes (or vice versa, to
> show raw bytes produced by their filter), but I'm having trouble coming
> up with one.
Your patch below only implements the "tame the raw bytes that come
out of their filter", which is quite agreeable.
> I.e., something like this would probably help your case without hurting
> anybody:
> ...
>
> I can't help but feel this is the tip of a larger iceberg, though. E.g.,
> what about characters outside of the terminal's correct encoding? Or
> broken UTF-8 characters?
Hmph. If you use it as a "built-in" that is a fallback for
diffFilter, i.e. use it only when the end user does not have one,
then users can override whatever wrong thing the built-in logic does
so... ;-)
next prev parent reply other threads:[~2017-10-17 1:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 13:33 Consider escaping special characters like 'less' does Joris Valette
2017-10-15 14:15 ` Jason Pyeron
2017-10-15 15:46 ` Andreas Schwab
2017-10-15 16:39 ` Joris Valette
2017-10-15 20:06 ` Jeff King
2017-10-15 21:37 ` Joris Valette
2017-10-16 22:13 ` Jeff King
2017-10-16 22:47 ` Andreas Schwab
2017-10-16 22:58 ` Jeff King
2017-10-17 1:13 ` Junio C Hamano [this message]
2017-10-17 2:45 ` Jeff King
2017-10-22 12:27 ` Jason Pyeron
2017-10-23 0:45 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk1zur2yp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=joris.valette@gmail.com \
--cc=jpyeron@pdinc.us \
--cc=peff@peff.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.