From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: "Christian Couder" <christian.couder@gmail.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Michael Haggerty" <mhagger@alum.mit.edu>,
"Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH 2/3] t1301: move movebits() to test-lib-functions.sh
Date: Thu, 22 Jun 2017 22:31:09 -0700 [thread overview]
Message-ID: <xmqqk243fexu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <455cbce5-97eb-2fdc-6e38-b4feb4daaa6e@ramsayjones.plus.com> (Ramsay Jones's message of "Fri, 23 Jun 2017 00:09:59 +0100")
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> On 22/06/17 20:52, Junio C Hamano wrote:
>> Christian Couder <christian.couder@gmail.com> writes:
>>
>>> As the movebits() function can be useful outside t1301,
>>> let's move it into test-lib-functions.sh, and while at
>>> it let's rename it test_movebits().
>>
>> Good thinking, especially on the renaming.
>
> Err, except for the commit message! :-D
>
> Both the commit message subject and the commit message body
> refer to _move_bits() rather than _mode_bits() etc.
> (So, three instances of s/move/mode/).
Wow, I shouldn't give praising reviews too easily ;-)
Good eyes, thanks.
next prev parent reply other threads:[~2017-06-23 5:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 19:01 [PATCH 1/3] read-cache: use shared perms when writing shared index Christian Couder
2017-06-22 19:01 ` [PATCH 2/3] t1301: move movebits() to test-lib-functions.sh Christian Couder
2017-06-22 19:52 ` Junio C Hamano
2017-06-22 23:09 ` Ramsay Jones
2017-06-23 5:31 ` Junio C Hamano [this message]
2017-06-23 15:12 ` Christian Couder
2017-06-22 19:01 ` [PATCH 3/3] t1700: make sure split-index respects core.sharedrepository Christian Couder
2017-06-22 19:53 ` Junio C Hamano
2017-06-22 20:19 ` Christian Couder
2017-06-22 20:25 ` Junio C Hamano
2017-06-22 21:07 ` Christian Couder
2017-06-22 19:51 ` [PATCH 1/3] read-cache: use shared perms when writing shared index Junio C Hamano
2017-06-23 15:14 ` Christian Couder
2018-11-13 15:22 ` Ævar Arnfjörð Bjarmason
2018-11-13 15:32 ` [RFC/PATCH] read-cache: write all indexes with the same permissions Ævar Arnfjörð Bjarmason
2018-11-13 16:55 ` Duy Nguyen
2018-11-13 17:34 ` Ævar Arnfjörð Bjarmason
2018-11-16 17:41 ` Christian Couder
2018-11-16 19:07 ` SZEDER Gábor
2018-11-16 19:19 ` Duy Nguyen
2018-11-17 6:52 ` Christian Couder
2018-11-17 12:38 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk243fexu.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.