From: Junio C Hamano <gitster@pobox.com>
To: Andreas Heiduk <asheiduk@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] add [--] to usage of filter-branch
Date: Fri, 09 Jun 2017 22:14:17 +0900 [thread overview]
Message-ID: <xmqqk24l717a.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <ef30e8f5-8206-7b42-e229-6cd4b0492e76@gmail.com> (Andreas Heiduk's message of "Mon, 5 Jun 2017 10:51:09 +0200")
Andreas Heiduk <asheiduk@gmail.com> writes:
> Am 03.06.2017 um 12:17 schrieb Andreas Heiduk:
>> Signed-off-by: Andreas Heiduk <asheiduk@gmail.com>
>> ---
>> Documentation/git-filter-branch.txt | 3 ++-
>> git-filter-branch.sh | 2 +-
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt
>> index 45c849d8c..1efdda804 100644
>> --- a/Documentation/git-filter-branch.txt
>> +++ b/Documentation/git-filter-branch.txt
>> @@ -86,7 +86,8 @@ OPTIONS
>> This is not a real filter executed for each commit but a one
>> time setup just before the loop. Therefore no commit-specific
>> variables are defined yet. Functions or variables defined here
>> - can be used or modified in the following filter steps.
>> + can be used or modified in the following filter steps except
>> + the commit filter, for technical reasons.
>
> I'll move that into the previous commit.
Yeah, the description of "technical limitation" is different from
clarifying the disambiguating "--" in the documentation.
I am curious what the "technical reason" really is, though ;-)
next prev parent reply other threads:[~2017-06-09 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 10:17 [PATCH 1/2] add setup step to filter-branch Andreas Heiduk
2017-06-03 10:17 ` [PATCH 2/2] add [--] to usage of filter-branch Andreas Heiduk
2017-06-05 8:51 ` Andreas Heiduk
2017-06-09 13:14 ` Junio C Hamano [this message]
2017-06-09 14:33 ` Andreas Heiduk
2017-06-05 2:15 ` [PATCH 1/2] add setup step to filter-branch Junio C Hamano
2017-06-09 5:49 ` Jeff King
2017-06-09 13:11 ` Junio C Hamano
2017-06-10 8:54 ` [PATCH v2 " Andreas Heiduk
2017-06-10 8:54 ` [PATCH v2 2/2] add [--] to usage of filter-branch Andreas Heiduk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk24l717a.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=asheiduk@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.