Re: What's cooking in git.git (Nov 2016, #06; Mon, 28)

[Junio C Hamano <gitster@pobox.com>]

Stefan Beller <sbeller@google.com> writes:

> On Mon, Nov 28, 2016 at 4:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> * sb/push-make-submodule-check-the-default (2016-10-10) 2 commits
>>  - push: change submodule default to check when submodules exist
>>  - submodule add: extend force flag to add existing repos
>>
>>  Turn the default of "push.recurseSubmodules" to "check" when
>>  submodules seem to be in use.
>>
>>  Need to rebase on hv/submodule-not-yet-pushed-fix and then consider
>>  merging to 'next'.
>
> The rebase is without merge conflicts, so I assume there is no
> work needed by me here.

Correct.

>> * sb/submodule-intern-gitdir (2016-11-22) 5 commits
>>  - SQUASH
>>  - submodule: add embed-git-dir function
>>  - test-lib-functions.sh: teach test_commit -C <dir>
>>  - submodule helper: support super prefix
>>  - submodule: use absolute path for computing relative path connecting
>>
>>  A new submodule helper "git submodule embedgitdirs" to make it
>>  easier to move embedded .git/ directory for submodules in a
>>  superproject to .git/modules/ (and point the latter with the former
>>  that is turned into a "gitdir:" file) has been added.
>>
>>  Need to read it over again, deal with SQUASH, and may ask for a
>>  reroll.
>
> Ok, I looked over it again and I may see some issues:

OK then I'll procrastinate on this.

> That slipped by me. Will review.
>
>> * sb/attr (2016-11-11) 35 commits
>>  - completion: clone can initialize specific submodules
>>  - clone: add --init-submodule=<pathspec> switch
>>  - submodule update: add `--init-default-path` switch
>
> I may end up rerolling these top three patches as its own series
> again without the underlying pathspec support.
>
> I will investigate if we need the mutex at all for the attribute
> code or if we can initialize all attrs (in the pathspecs) before the
> threaded preload_index takes place. That sounds cleaner to me,
> but I do not prioritize it as high.

OK.

Thanks.