All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jim Hill <gjthill@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v3] sha1_file: pass empty buffer to index empty file
Date: Tue, 19 May 2015 12:48:21 -0700	[thread overview]
Message-ID: <xmqqk2w473i2.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqq1tic8lgj.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Tue, 19 May 2015 11:35:08 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Yuck; please discard the previous one.  write_in_full() side is also
> writing into that process, so we should do the same.

OK, without these two, and with the "true" filter that does not read
anything reinstated in the test script, t0021 used to die

    i=0; while sh t0021-conversion.sh; do i=$(( $i + 1 )); done

after 150 iteration or so for me.  With these two, it seems to go on
without breaking (I bored after 1000 iterations), so I'd declare it
good enough ;-)

  reply	other threads:[~2015-05-19 19:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 17:23 [PATCH] sha1_file: pass empty buffer to index empty file Jim Hill
2015-05-14 18:43 ` Junio C Hamano
2015-05-14 23:17   ` [PATCH v2] " Jim Hill
2015-05-15 18:01     ` Junio C Hamano
2015-05-15 23:31       ` Jim Hill
2015-05-16 18:48         ` Junio C Hamano
2015-05-16 20:06           ` [PATCH v3] " Jim Hill
2015-05-16 23:22             ` Junio C Hamano
2015-05-17 17:37             ` Junio C Hamano
2015-05-17 19:10               ` Junio C Hamano
2015-05-18  0:41                 ` [PATCH v4] " Jim Hill
2015-05-19  6:37                 ` [PATCH v3] " Jeff King
2015-05-19 18:11                   ` Junio C Hamano
2015-05-19 18:17                     ` Junio C Hamano
2015-05-19 18:35                       ` Junio C Hamano
2015-05-19 19:48                         ` Junio C Hamano [this message]
2015-05-19 22:14                           ` Jeff King
2015-05-20 17:03                             ` Junio C Hamano
2015-05-19 19:40                     ` Eric Sunshine
2015-05-19 22:09                     ` Jeff King
2015-05-20 17:25                       ` Junio C Hamano
2015-05-20 17:38                         ` Jeff King
2015-05-14 23:26   ` [PATCH] " Jim Hill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk2w473i2.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gjthill@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.